Repository navigation
fix(ui): SQL toolbar row states its control size and a test holds it - #1470
Merged
Merged
Conversation
The row had no hand-written sizes and happened to be md; it is now inside a QueryaControlScope(md) and a test measures the run split button, the explain button, the editor icon buttons and the session menu at 32 px. Refs #1439
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the rest of #1439 (the ERD, chart and results toolbars went in #1461).
The SQL header row had no hand-written sizes and relied on the default. It is now wrapped in
QueryaControlScope(md)so the intent is explicit and survives a changed default, and a test measures the Execute split button (both halves), Explain, the editor icon buttons and the Session menu at 32 px with an open transaction.Refs #1331