Skip to content

ux(sql-workspace): editor and results framed alike, no glow, one place for the row count (#1558, stage 1, part 2) - #1728

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
epic/sql-workspace-surfaces
Oct 18, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
epic/sql-workspace-surfaces

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1558 (stage 1, second PR; after #1727).

Surfaces. The editor was a rounded card with an accent glow (blurRadius: 28), the toolbar a flat strip, the results nothing at all.

  • SqlEditorChrome is one framed card now: radius 14, a 1 px border, no glow. The border takes the accent only while the editor has the keyboard (showFocus).
  • The results sit in the same card (SqlEditorChrome(background: workbench.surface, showFocus: false)) with the 12 px inset the editor has, around the plan strip, the plan tree and the results tab alike.
  • The dialogs' inline SQL fields (inlineFieldDecoration) are unchanged; they are a different component.

One place for the row count. The mode bar printed 12 row(s). and the status bar 12 rows, 8 cols.

  • The mode bar now leaves a plain N row(s). to the status bar. It keeps what the status bar has not got: a truncation note, Rows affected, a script's outcome, a status with an edit hint, and the filtered count (3 of 12 rows). Without any status line (the table browser) it shows the count as before.
  • The status bar says 1 row, 1 col instead of 1 rows.
  • The elapsed time stays in both: the status bar's is the last run anywhere, the bar's belongs to the shown tab. I did not merge them; say if you want it gone from one.

Tests: sql_editor_chrome_test (no shadow, accent border only while focused, a card with showFocus: false keeps its border and takes its background), results_tab_test (the bar for a plain count, a truncation note, a count with a hint, no status line, affected rows), querya_status_bar_test (singular). Main-screen, workspace, e2e and guard suites pass locally (723).

Not checked on screen this time: I could not drive the running app (the window sat beside another one and my pointer input did not land), so this PR has no screenshots; the before/after pair for dark and light comes with the end of stage 1. Not in this PR: stage 2 (control rows).

…e glow; the mode bar leaves a plain row count to the status bar (#1558)
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit ba17955 into dev Oct 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant