Repository navigation
ux(sql-workspace): editor and results framed alike, no glow, one place for the row count (#1558, stage 1, part 2) - #1728
Merged
Conversation
…e glow; the mode bar leaves a plain row count to the status bar (#1558)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1558 (stage 1, second PR; after #1727).
Surfaces. The editor was a rounded card with an accent glow (
blurRadius: 28), the toolbar a flat strip, the results nothing at all.SqlEditorChromeis one framed card now: radius 14, a 1 px border, no glow. The border takes the accent only while the editor has the keyboard (showFocus).SqlEditorChrome(background: workbench.surface, showFocus: false)) with the 12 px inset the editor has, around the plan strip, the plan tree and the results tab alike.inlineFieldDecoration) are unchanged; they are a different component.One place for the row count. The mode bar printed
12 row(s).and the status bar12 rows, 8 cols.N row(s).to the status bar. It keeps what the status bar has not got: a truncation note,Rows affected, a script's outcome, a status with an edit hint, and the filtered count (3 of 12 rows). Without any status line (the table browser) it shows the count as before.1 row, 1 colinstead of1 rows.Tests:
sql_editor_chrome_test(no shadow, accent border only while focused, a card withshowFocus: falsekeeps its border and takes its background),results_tab_test(the bar for a plain count, a truncation note, a count with a hint, no status line, affected rows),querya_status_bar_test(singular). Main-screen, workspace, e2e and guard suites pass locally (723).Not checked on screen this time: I could not drive the running app (the window sat beside another one and my pointer input did not land), so this PR has no screenshots; the before/after pair for dark and light comes with the end of stage 1. Not in this PR: stage 2 (control rows).