Repository navigation
chore(ui): Gap from the gap package; 7 files off shadcn; a ratchet on shadcn imports (#1729) - #1737
Merged
Merged
Conversation
…drop shadcn; a ratchet on shadcn imports (#1729)
ZhuchkaTriplesix
force-pushed
the
chore/gap-direct
branch
from
October 18, 2026 14:19
89f6f94 to
fef14d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1729. Part of #1465.
gap: ^3.0.1is a direct dependency now (the version shadcn already pulled in, so nothing changes at runtime). The barrel exportspackage:gap/gap.dartand hidesGap,MaxGap,SliverGapfrom its shadcn re-export.import 'package:shadcn_flutter/...'hidesGap, and a file that usesGapwithout the barrel importspackage:gap/gap.dart(includingresult_grid_view.dart, whose part files use it). No file takesGapfrom shadcn any more.Gapand Flutter types (vertical_split_pane,erd_table_card,erd_search_panel,update_available_badge,query_editor_tab,grid_column_sizer,grid_selection_manager). 59 -> 52 files import the package.shadcn_imports_ratchet_test: lists the 52 files that still import shadcn; a new file may not start, and a file that drops the import must leave the list. A second test checks that no unprefixed shadcn import bringsGap.Found on the way, for #1735: shadcn has its own
ThemeMode(ThemeControlleruses it), soquerya_core_commands.dartcannot takeThemeModefrom Material until the shell moves.dart analyzeis clean; guards and the workspace, ERD, Mongo, main-screen, shared, layout and updater suites pass locally (1096 tests).