Skip to content

refactor(connections): colours through context.colors, with a guard (#1731, connections) - #1739

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
refactor/colors-connections
Oct 18, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
refactor/colors-connections

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Part of #1731 (first folder: features/connections, ~200 reads). Epic #1465.

Mechanical, no visual change:

  • final theme = Theme.of(context); + theme.colorScheme.x → final colors = context.colors; + colors.x (15 files);
  • Theme.of(context).colorScheme → context.colors (ssh_tunnel_section, environment_section);
  • the sidebar folder menu takes QueryaUiColors instead of shadcn's ThemeData;
  • driver_icon read Material's colorScheme.primary, which querya_material_theme.dart maps from the same primary; it reads context.colors.primary now.

context.colors reads the shell theme while there is one (#1730), so every value is the one the code read before, mid theme animation included.

New guard colors_through_context_test.dart: in the folders it lists, no colorScheme, Theme.of( or ColorScheme. It starts with lib/features/connections; each next folder of #1731 adds itself in its PR.

dart analyze is clean; guards, connections, main-screen (goldens included) and e2e suites pass locally (311).

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 6ff0f52 into dev Oct 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant