Repository navigation
refactor(connections): colours through context.colors, with a guard (#1731, connections) - #1739
Merged
Merged
Conversation
…eeps the folder off the theme's colorScheme (#1731)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1731 (first folder:
features/connections, ~200 reads). Epic #1465.Mechanical, no visual change:
final theme = Theme.of(context);+theme.colorScheme.x→final colors = context.colors;+colors.x(15 files);Theme.of(context).colorScheme→context.colors(ssh_tunnel_section,environment_section);QueryaUiColorsinstead of shadcn'sThemeData;driver_iconread Material'scolorScheme.primary, whichquerya_material_theme.dartmaps from the sameprimary; it readscontext.colors.primarynow.context.colorsreads the shell theme while there is one (#1730), so every value is the one the code read before, mid theme animation included.New guard
colors_through_context_test.dart: in the folders it lists, nocolorScheme,Theme.of(orColorScheme. It starts withlib/features/connections; each next folder of #1731 adds itself in its PR.dart analyzeis clean; guards, connections, main-screen (goldens included) and e2e suites pass locally (311).