Repository navigation
refactor(settings, workspace): colours through context.colors (#1731) - #1741
Merged
Merged
Conversation
…heme_picker_button drops its shadcn import (#1731)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1731 (folders
features/settingsandfeatures/workspace, ~150 reads). Epic #1465.Mechanical, no visual change:
Theme.of(context).colorScheme(one-line and wrapped over several lines) andtheme.colorScheme→context.colors;ColorSchemetype of parameters and fields →QueryaUiColors(the grid cell, row and header renderers,Preferencespanes, the theme picker); thecolorSchemefield of the grid renderers iscolors;ThemePreviewCardreads the previewed theme's colours fromQueryaTheme.colors.Theme.of(context)stays where it gives something that is not a colour (brightness,radiusSmin the destructive-query and DML dialogs and the grid tooltip): the guard forbidscolorSchemeandColorScheme, notTheme.of, until the shell moves (refactor(app): replace ShadcnApp with MaterialApp and our theme scope (#1465) #1735).theme_picker_button.dartno longer imports shadcn (ratchet list: 37 → 36).Guard
colors_through_context_test.dartnow coversconnections,mongodb,redis,settingsandworkspace. It caught one wrappedTheme.of(context)\n.colorSchemeinresults_tab.dartthat my search had missed. Two more of that shape are left inonboardingandextensions, for their folders.dart analyzeis clean; guards, settings, workspace, main-screen (goldens included) and e2e suites pass locally (800).