Repository navigation
refactor(misc): read colours through context.colors across shared and misc features (#1731) - #1744
Merged
Merged
Conversation
… misc features (#1731) Migrate colour reading from Theme.of(context).colorScheme / shadcn.Theme.of(context).colorScheme to context.colors across: - lib/shared - lib/app - lib/features/command_palette - lib/features/erd - lib/features/help - lib/features/main_screen - lib/features/onboarding - lib/features/recovery - lib/features/results - lib/features/updater Drop package:shadcn_flutter from erd_export_data.dart, erd_edge_tip_label.dart, and update_changelog_view.dart, and update the shadcn ratchet accordingly. Add all 10 locations to the migrated list in colors_through_context_test.dart. Part of #1731.
ZhuchkaTriplesix
added
theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1731 (folders
shared,app,command_palette,erd,help,main_screen,onboarding,recovery,results,updater). Epic #1465.Mechanical, no visual change:
•
Theme.of(context).colorSchemeandshadcn.Theme.of(context).colorScheme→context.colorsacross all 10 locations;• Parameter/variable types
ColorScheme→QueryaUiColors;•
erd_export_data.dart,erd_edge_tip_label.dart, andupdate_changelog_view.dartdrop theirpackage:shadcn_flutterimports. They leave the shadcn ratchet: 32 → 29 files;•
colors_through_context_test.dartnow covers all oflib/exceptlib/core(which will be migrated next in the final step of #1731).dart analyzeis clean (0 issues); guards, features-app, ERD, recovery, results, updater, and shared suites pass locally (over 500 tests).