Repository navigation
refactor(core): read colours through context.colors across core (#1731) - #1745
Merged
Merged
Conversation
Read colours through context.colors / QueryaUiColors across lib/core and expand colors_through_context_test.dart to cover all of lib/ except lib/core/theme (which bridges to the shadcn shell and leaves with #1465 step 5). Drop shadcn_flutter imports in querya_split_handle.dart and theme_editor_draft.dart, updating the ratchet guard accordingly. Closes #1731.
ZhuchkaTriplesix
added
theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1731 (
core). Completes #1731. Epic #1465 (step 3b).Mechanical, no visual change:
•
Theme.of(context).colorSchemeandtheme.colorScheme→context.colors/theme.colorsacrosslib/core(querya_split_handle.dart,querya_hover_surface.dart,querya_tree_indent_guide.dart,querya_semantic_palette.dart,theme_editor_draft.dart);•
querya_split_handle.dartandtheme_editor_draft.dartdrop theirpackage:shadcn_flutterimports. They leave the shadcn ratchet: 29 → 27 files;•
colors_through_context_test.dartnow covers all oflib/exceptlib/core/theme(which bridges to the shadcn shell and leaves with #1465 step 5);•
dart analyzeis clean (0 issues); guards and core suites pass locally (over 2000 tests).Closes #1731.