Repository navigation
Add multilanguage support - #12
Draft
QuickWrite wants to merge 6 commits into
Draft
QuickWrite wants to merge 6 commits into
QuickWrite wants to merge 6 commits into
Conversation
Adding the basis for a very simple translation system
Even though the array should NEVER be out of bounds, it could theoretically happen. As such a check to harden the application is being added.
It seems like the router itself was sending the response when a request failed instead of the router. This is by itself fine. However this is normally the job of the controller which can do more logic at the end to ensure that the response is correct.
Especially with CI it is important that ALL the information is being printed. as such it should be on by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application currently only runs on one locale. However it could be sensible to rebuild this to enable other locales as well.