Repository navigation
Trigger signature help after function completion - #1878
Merged
Merged
Conversation
Member
Author
|
@eitsupi Would you like to review this PR? |
Member
|
I'm sorry, I didn't notice. I'll take a look. |
eitsupi
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepting a function completion such as
fun1insertsfun1()but previously left parameter hints closed because snippet insertion does not fire signature-help trigger characters. Add completion middleware that runs VS Code's parameter-hints command after accepting function, method, or constructor snippets that place the cursor inside the call.The middleware respects the document's
editor.parameterHints.enabledsetting and preserves existing completion commands. The behavior is implemented entirely in vscode-R and works with the existing languageserver snippets.Automatically opening signature help after completion is an established editor integration pattern. The implementation location varies:
editor.action.triggerParameterHintson the client for function-call snippets with parameters, respecting the parameter-hints setting.LSP allows a command to run after completion insertion, but the parameter-hints command is editor-specific. This PR follows Go and clangd by keeping that behavior in VS Code's completion middleware. This avoids adding a command to every eligible item in the server's initial completion response and keeps editor settings in the client; the selected item's command can still round-trip during completion resolution.
Validation:
pnpm run pretestpnpm run typecheckpnpm run lintgit diff --check origin/main...HEAD