Repository navigation
Fix hardcoded user path in silent VBS launcher - #15
Open
0xdefec71f wants to merge 1 commit into
Open
0xdefec71f wants to merge 1 commit into
0xdefec71f wants to merge 1 commit into
Conversation
Replace the hardcoded user-specific PowerShell script path with dynamic path resolution. Previously, the launcher used a hardcoded path containing "C:\Users\User", which caused it to fail for users with a different Windows username. The VBS launcher now determines its own directory using WScript.ScriptFullName and starts DimOLED.ps1 from the same directory. This ensures the launcher works correctly for all Windows users and installation paths without requiring any user-specific configuration or modifications during installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Replace the hardcoded user-specific PowerShell script path with dynamic path resolution. Previously, the launcher used a hardcoded path containing "C:\Users\User", which caused it to fail for users with a different Windows username.
The VBS launcher now determines its own directory using WScript.ScriptFullName and starts DimOLED.ps1 from the same directory.
This ensures the launcher works correctly for all Windows users and installation paths without requiring any user-specific configuration or modifications during installation.
Verification