Repository navigation
Conversation
dhhoang
marked this pull request as ready for review
November 9, 2026 11:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enable operator-managed AMD GPU driver installation on Ubuntu 26.04.
Close #631 — Cannot build image for Ubuntu 26.04.
Technical Details
Ubuntu 26.04 builds now use the
resoluterepository and installlinux-modules-${KERNEL_FULL_VERSION}. Earlier Ubuntu releases continue usinglinux-modules-extra.When
DeviceConfig.spec.driver.versionis omitted, the operator selects31.50for Ubuntu 26.04. Initial driver-version labels now resolve the default separately for each node and return an error if none exists. The Helm instructions explain how to override the chart's explicit driver version to use this default.The build also unpacks
.ko.zstmodules before runningdepmod, giving Kernel Module Management (KMM) the.kofiles it expects for signing. Addingamddrm_exec.koandamddrm_suballoc_helper.koto the Ubuntu 26.04 signing list covers all nine AMD modules in the tested releases.I also fixed an issue in
prepareimage: duplicate flag registrations.Test Plan
7.0.0-43-generic31.40.1,31.50,31.607.0.0-42-generic31.50Test Result
All configurations above passed. On both GPU models, matrix multiplication and neural-network inference matched CPU results before and after reboot. MI300X also recovered its GPU workload after automatic driver upgrades from the 31.50 default to 31.60 and back, and after changing kernels in both directions.
Unit tests,
go vet, and Helm rendering checks passed. KMM signed all nine modules with driver 31.50 and kernel 7.0.0-42; independent verification accepted each signature and rejected altered module contents. The final container image contained no copy of the private signing key.Secure Boot enforcement and host virtualization driver installation were not tested. Driver 31.60 logged
RAS early init service failure! ret:-95on MI300X; computation and health checks passed.Submission Checklist