Repository navigation
fix(tui): drop the selection bar from the esc menu - #15
Merged
Merged
Conversation
The bar sat at the left edge of the box, far from the centered labels. The selected item is still shown in bold accent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The Escape menu now uses centered labels without a left selection bar, while retaining bold accent styling for the selected item. This is a presentation-only change with no change to menu actions or stored data. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The esc menu drew a little
▌bar next to the selected item, but the items are centered, so it floated alone at the left edge of the box. It's gone now; the selected item still shows in bold accent. The labels also center under the logo now, one cell left of before.Proved with
scripts/shot.shbefore/after on demo data (esc, up to Quit), plusgo test ./...,go vet,gofmtclean.Reviewed with sol-loop: 1 round with gpt-6.2-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code
Note
Remove selection bar from TUI esc menu main page
Main-page names in panel.go are now rendered centered within the panel content width instead of going through the item renderer. The selected name uses bold accent styling; other names use the text style. Behavioral Change: the esc menu main page no longer shows an item bar behind the selected entry.
Macroscope summarized ddad02e.