Repository navigation
fix: throw ParseException when ':' or 'e' is missing - #21
Merged
Merged
Conversation
decode() did not check strpos() for false. For 'l0a' the string length ran to the end of the input, the position never moved, and the list loop appended empty strings until PHP ran out of memory. Also report a dictionary key without a value directly (was the FIXME in testDecodeDictionaryWithKeyButWithoutValue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
ParseException('Missing colon after string length')when there is no:. Before,l0alooped and appended empty strings until PHP ran out of memory.ParseException('Unterminated bencode integer')when there is noe.enow throwsDictionary key without value: <key>. This replaces the// FIXMEmessage intestDecodeDictionaryWithKeyButWithoutValue.Tests: 3 new cases in
DecodeTest(l0a,d3:key0,li12). Before the fix the suite dies with "Allowed memory size exhausted"; after: 293 tests OK.I also ran 8k random and mutated inputs against a strict BEP 3 decoder: no crashes left. The only differences are the documented ones (unsorted keys are accepted and sorted, ints over PHP_INT_MAX are rejected).