Skip to content

chore(landing): the ledger page leaves the SEC repository out - #565

Merged
jfrench9 merged 1 commit into
mainfrom
chore/ledger-landing-no-sec
Nov 18, 2026
Merged

jfrench9 merged 1 commit into
mainfrom
chore/ledger-landing-no-sec

Conversation

@jfrench9

Copy link
Copy Markdown
Member

Summary

Copy only. roboledger.ai sells the general ledger; the SEC repository is robosystems.ai's to sell. The hero and the sections below it no longer mention it.

  • Hero: "with your numbers beside public companies'" removed.
  • Built on RoboSystems: the subhead no longer pairs the books with the public filings; the SEC EDGAR data-source card is removed; the group card reads "in one ledger, in XBRL's standard terms".
  • How it works, step 02: the SEC filings clause removed.
  • For the builder: "Compare across companies" is the group's companies and periods on the same reporting concepts.
  • FAQ: no public-company comparison and no SEC subscription price.
  • The Harbinger block names the third workflow ("a peer benchmark") without the SEC repository's price.
  • One keyword ("benchmark small business against public companies") removed.

Not changed here: the hero animation still has a beat comparing the demo company with public peers from the SEC graph (public/demos/hero.js). Taking it out means retiming the demo, so it is a separate change.

Testing

npm run test:all passes (1,263 tests). Not viewed in a browser.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AGZDQgM7TRH6Fnuhp8TV2J

@github-actions github-actions Bot added the change:normal Normal change: automated review documented on the pull request before merge label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Change classification: normal — platform or application code changed.

A normal change carries a documented automated review on this pull request before merge, in place of a second human approver. The change-classification job requests that review and passes once it has been posted. Recorded by the change-classification job.

@jfrench9

Copy link
Copy Markdown
Member Author

@claude please review this PR

@claude

claude Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Claude finished @jfrench9's task in 16s —— View job


PR review: ledger landing page leaves out the SEC repository

  • Read the diff
  • Checked for leftover SEC / public-company references in the landing components
  • Checked the layout after the SEC card removal

Overall: The change is small, copy-only and does what the description says. The wording reads cleanly and the JSX is valid, so I'd approve it with the two small notes below. I haven't run the tests or viewed it in a browser; I'm relying on the PR's test:all result.

Findings

  1. Leftover public-company reference (minor, but it contradicts the PR's goal). src/components/landing/HeroSection.tsx:115 still has compares against public peers in the animation's label, which is the accessible description of the hero demo. The PR body says the animation beat is deferred because retiming it is a separate change. That covers the visual, but the label is just a string and can change now. As it stands, screen-reader users and any crawler reading the label still get the public-company pitch the PR removes everywhere else. Dropping that clause now means the label no longer describes a beat the animation still shows, so you could instead change it together with the animation. Either is defensible, but note the mismatch in the follow-up.

  2. "A peer benchmark" is now unexplained (nit). HarbingerSection.tsx:23 names a "peer benchmark" workflow, but without the SEC repository there is nothing on the page saying what it benchmarks against. A visitor may read it as an unsupported claim. If it does run against the SEC data, saying "peer benchmark" is fine on a robosystems-adjacent page. If you want the ledger page fully clean, consider something tied to what this product holds, such as "a group comparison". It's a copy call, so leave it if it's intentional.

Checked, no problems

  • PlatformSection.tsx: removing the SEC card leaves the Data Sources column as QuickBooks and Plaid, inside space-y-4. The outer lg:grid-cols-3 is unaffected, so the layout holds. That column is now shorter than the other two, so it's worth a quick look in a browser to check the vertical balance, as the PR notes it wasn't viewed.
  • AgentSurface.tsx: the resolve-element tool chip is dropped along with the SEC wording. Confirm that this matches the tools the capability actually uses; build-fact-grid alone is fine if so.
  • FaqSection.tsx: the rewrapped JSX text is correct and the apostrophes are still escaped ('). The price sentence now flows straight into the open-source one with no dangling reference to the SEC subscription.
  • metadata.ts: removing the one keyword is clean. A repo-wide grep of the landing components found no other EDGAR, filers or public compan references.

@jfrench9
jfrench9 merged commit cfafafe into main Nov 18, 2026
7 checks passed
@jfrench9
jfrench9 deleted the chore/ledger-landing-no-sec branch November 18, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:normal Normal change: automated review documented on the pull request before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant