Repository navigation
feat(connections): Mercury's partner disclosures and a Disconnect dialog - #567
Conversation
…cury dialog Every screen of the Mercury flow carries Powered by Mercury, the wordmark, a mercury.com link and Mercury's not-a-bank disclosure, verbatim from its partner disclosure guidance; the Treasury checkbox carries the Treasury disclosure. A bank feed's delete dialog now reads Disconnect and says what is deleted and what stays.
…ny's token When the API lists Mercury with api_key required (no Mercury OAuth client), the form drops the Mercury sign-in and the Connect button waits for a token. The field says whose token it is: each company connects with its own.
|
Change classification: normal — platform or application code changed. A normal change carries a documented automated review on this pull request before merge, in place of a second human approver. The |
|
@claude please review this PR |
|
Claude finished @jfrench9's task in 24s —— View job Review of PR #567: Mercury disclosures and Disconnect dialogI read the full non-test diff against The change is clean and matches the repo conventions: the work is colocated, the disclosure is a single shared component, and the new props are backward compatible. I found no blocking bugs. The points below are small. Worth a look
Nits
Looks good
I'd merge after considering items 1 to 3. |
Every disconnecting provider's card button reads Disconnect, matching its dialog; the Treasury disclosure matches the checkbox label's size; the callback's loading state keeps the disclosure in view.
Summary
Mercury's production OAuth credentials are issued after its compliance team reviews a recorded demo showing "Powered by Mercury", its not-a-bank disclosure, a mercury.com link, and a way to disconnect. This puts all four on every screen of the Mercury flow, following Mercury's partner disclosure guidance (revised 2026-03-13), and makes a token-only deployment ask for each company's own Mercury token.
Changes
connections/components/MercuryDisclosure.tsx: Mercury's not-a-bank disclosure and its Treasury disclosure as verbatim constants, aPoweredByMercuryblock (wordmark, mercury.com link, disclosure), and a logomark on a white tile so the dark mark reads in dark mode. Logo files from Mercury's partner media kit inpublic/images/mercury_logo.svgandmercury_logomark.svg./connections, Mercury row): "banking*" carries an asterisk with the disclosure directly beneath it.MercurySetupForm): logo, "Powered by Mercury" with the disclosure under the asterisked "banking*"; the treasury checkbox reads "Include Mercury Treasury accounts" with Mercury's Treasury disclosure under it, at the label's size. The token field is labelled "Mercury API token for this company (read-only)" and says each company connects with its own. When the API lists Mercury withapi_keyrequired (no Mercury OAuth client), the Mercury sign-in is hidden and Connect waits for a token./connections/mercury-callback): the block on the loading, success, and error states, centred with the loader so it is in view while connecting.ConnectionCard): Mercury logo and the block. Every provider whose removal is a disconnect (QuickBooks, Mercury, Plaid) gets a labelled Disconnect button titled "Disconnect {provider}", matching its dialog; an external integration keeps the icon-only "Delete connection".DeleteConnectionModal): a bank feed (Mercury, Plaid) reads Disconnect {provider} and says what happens: access is given up, inbox lines and the counterparties only they used are deleted, posted entries stay without the provider's transaction details, and chart accounts stay but are unlinked. Mercury's carries the disclosure. The toast after a disconnect says "{Provider} disconnected", not "Connection deleted successfully".Deploy Notes
None. Works against the current API: without the new
required_configfrom the companion robosystems PR, the form behaves as before. Mercury stays dark in hosted production (CONNECTION_MERCURY_ENABLEDis off), so these screens are not visible there until it is turned on.Testing
npm run test:allgreen in the pre-commit hook on every commit (137 files, 1271 tests), with new tests for the disclosures, the Treasury disclosure, the token-required form, and the Disconnect dialog.npm run buildnot run; every changed screen was served by the dev server and exercised in the browser.🤖 Generated with Claude Code