Repository navigation
fix(operator): omit unset flags; regenerate and align docs with the server - #300
Merged
Merged
Conversation
…lign docs OperatorClient sent enable_rag and force_extended_analysis as null when the caller left them unset (the default), and the server types both as true/false, so a default query was refused with a 422. Unset flags are now omitted, as thread_id already was; tests pin both cases. Regenerated from the API's current descriptions, and the hand-written README and facade docstrings corrected against the server: statements take scope (consolidated is the older spelling), the chart templates include consolidation, document search is keyword-only, portfolio reads return active positions, and the graphs example uploads to a custom graph. Claude-Session: https://claude.ai/code/session_01AGZDQc4cAvYy1J8HDGLNEL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix (stable tier):
OperatorClientdefault requests were refused.query,execute_queryandexecute_operatorsentenable_ragandforce_extended_analysisasnullwhen the caller left them unset (the default); the server types both as true/false, so a default call got a 422 — the README's operator example included. Unset flags are now omitted, asthread_idalready was. No signature change; behaviour goes from refused to working. Tests pin both cases (unset → omitted, set → sent).Regeneration from the API's current descriptions. Generated tier, text only: no paths, fields or types change. It carries the description fixes in robosystems#2071, so merge or deploy order doesn't matter for behaviour — the docstrings simply read ahead until that PR ships.
Hand-written docs corrected against the server: statements take
scope(consolidatedis the older spelling); chart templates includeconsolidationand the 409 is per entity;create_reportis synchronous; eventsourceis validated against the graph's connections; document search is keyword-only with the rightsource_typelist; portfolio reads return active positions; the graphs README uploads to a custom graph (an entity graph refuses uploads).Test plan
just test-all— ruff, format, basedpyright, 752 passed🤖 Generated with Claude Code
https://claude.ai/code/session_01AGZDQc4cAvYy1J8HDGLNEL