Repository navigation
fix(api): anchor username validation regex - #1388
Open
ydvvdinesh wants to merge 1 commit into
Open
ydvvdinesh wants to merge 1 commit into
ydvvdinesh wants to merge 1 commit into
Conversation
- Anchor username validation RegExp with ^ and $ in EmbeddedChatApi.ts to prevent usernames with invalid characters from passing validation. - Add unit tests covering alphanumeric, space-to-dot replacement, symbols rejection, and empty username cases. Signed-off-by: Dinesh Yadav <bawwadinesh@gmail.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(api): anchor username validation regex
Acceptance Criteria fulfillment
/^[0-9a-zA-Z-_.]+$/) inEmbeddedChatApi.tsto prevent invalid characters from bypassing client-side validation.packages/api/src/EmbeddedChatApi.test.jsvalidating alphanumeric names, space normalization, symbols rejection, and boundary conditions.Description
In
EmbeddedChatApi.ts,updateUserUsernamepreviously checked username validity using/[0-9a-zA-Z-_.]+/. Because the regular expression lacked start (^) and end ($) anchors, any string containing at least one valid character (such asjohn@doe.com,user!name, orJohn Doe (Admin)) was treated as valid, bypassing client-side validation and submitting invalid usernames to the backend.Anchoring the RegExp with
/^[0-9a-zA-Z-_.]+$/ensures that the entire username contains only permitted characters (0-9,a-z,A-Z,-,_,.).PR Test Details
node --test packages/api/src/EmbeddedChatApi.test.js