Repository navigation
[Fix] Failed worker packaging removes the previous release checksum - #3629
Open
roomote-roomote[bot] wants to merge 3 commits into
Open
roomote-roomote[bot] wants to merge 3 commits into
roomote-roomote[bot] wants to merge 3 commits into
Conversation
Contributor
|
No new code issues found. Reviewed the deterministic GITHUB_SHA fixture, extracted COMMIT assertion, and updated release-workflow expectation against the packaging script. Current-head CI lint, type checking, and Knip passed; tests and the app Docker build were still running when inspected. See session Reviewed f44fe16 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 30, 2026 05:15
This was referenced Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal maintainer-requested reliability work; no issue was opened.
Why this PR exists
A failed worker release package should leave the last complete release usable. Previously, packaging removed its checksum before copying or archiving the replacement, and a failed tar left both the staging tree and partial archive behind.
What changed
This keeps a previous release usable after copy, tar or checksum-generation failure, and avoids deleting an unrelated same-named directory in the checkout. Archive and checksum publication remain two filesystem renames; this does not claim transactional multi-file publication, concurrent compiler isolation or SIGKILL cleanup.
How it was tested
c97173a7: ran the actual packaging script with native tar/gzip under a controlled file-size limit. It failed with exit 2, preserved the previous archive, deleted its checksum, and retained a partial archive/staging tree.f44fe16f: repeated the same stimulus and a native TERM interruption; both previous files survived and unpublished files were cleaned. Compilation is substituted by prebuilt synthetic assets only in these failure fixtures.sha256sum -c.pnpm lint,pnpm check-types,pnpm check-types:fastandpnpm knippassed. Browser proof is not applicable to this shell packaging path. Hosted publication and macOS execution were not exercised.Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetNo changeset: development/release tooling failure cleanup only.