Skip to content

Missing connections when the config is not re-readable. - #1102

Open
JamesC1 wants to merge 3 commits into
RsyncProject:masterfrom
JamesC1:configReread
Open

JamesC1 wants to merge 3 commits into
RsyncProject:masterfrom
JamesC1:configReread

Conversation

@JamesC1

@JamesC1 JamesC1 commented Sep 26, 2026 •

Copy link
Copy Markdown

Edit: typo in English text.

I think that this is a request for a documentation change, mostly or only.

It is comon knowledge among rsync developers that a daemon rereads its config multiple times, with no warnings when it changes:
#409 (comment)

I exercised this behaviour by creating a temporary, scruffy rsync daemon, and attempting to configure it with a bash process substitution.

There is currently no warning the manual. This request contains my proposed wording.

As well or instead, people might prefer a code change, so that rsync daemons read the whole config and report warnings in the log when it changes. The code for that change is beyond me.

My configuration details and test case:

$ rsync --version
rsync  version 3.4.1  protocol version 32
...
$ uname -a
Linux debian 6.12.107+deb13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.107-1 (2026-08-29) x86_64 GNU/Linux

I was writing a scruffy, temporary rsync daemon, and tried to have only the shellscript that launched it:

#!/bin/bash
set -x

# to start the server

/usr/bin/rsync \
--log-file=/tmp/2600-log.txt \
--config=<(echo '
port=2601
globalBadParameter=false

[everything]
path = /
exclude = /*/*
everythingBadParameter=false

') \
--no-detach \
--ipv4 \
--daemon 


# to test:
#- log into three terminals as an ordinary user
#- touch /tmp/2600-log.txt
#- tail -f /tmp/2600-log.txt
#- start rsync as a user
#-- globalBadParameter is reported in the log
#
#- rsync --port 2601 localhost::
#-- log reports the request for the module list
#-- log does not report everythingBadParameter
#-- rsync command tacitly reports zero modules

Add warning about rsyncd.conf file reading behavior.
Corrected configuration syntax and added a warning about re-reading the config file.
Corrected a grammatical error in the warning message about config file reading behavior.

@steadytao steadytao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a short note under --config and extend the existing reread paragraph in rsyncd.conf.5.md rather than adding a second warning section. The claim about there being no warning when a modified configuration is reread is unnecessary.

Comment thread rsync.1.md
you can specify any remote shell you like, either by using the [`-e`](#opt)
command line option, or by setting the [`RSYNC_RSH`](#) environment variable.

--

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Comment thread rsync.1.md

## USAGE

--

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment thread rsyncd.conf.5.md
> proxy_pass localhost:873;
> proxy_protocol on; # Requires rsyncd.conf "proxy protocol = true"
> proxy_timeout 1m;
> proxy_tasimeout 1m;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants