Conversation
Add warning about rsyncd.conf file reading behavior.
Corrected configuration syntax and added a warning about re-reading the config file.
Corrected a grammatical error in the warning message about config file reading behavior.
steadytao
requested changes
Sep 26, 2026
steadytao
left a comment
Member
There was a problem hiding this comment.
Just add a short note under --config and extend the existing reread paragraph in rsyncd.conf.5.md rather than adding a second warning section. The claim about there being no warning when a modified configuration is reread is unnecessary.
| you can specify any remote shell you like, either by using the [`-e`](#opt) | ||
| command line option, or by setting the [`RSYNC_RSH`](#) environment variable. | ||
|
|
||
| -- |
|
|
||
| ## USAGE | ||
|
|
||
| -- |
| > proxy_pass localhost:873; | ||
| > proxy_protocol on; # Requires rsyncd.conf "proxy protocol = true" | ||
| > proxy_timeout 1m; | ||
| > proxy_tasimeout 1m; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: typo in English text.
I think that this is a request for a documentation change, mostly or only.
It is comon knowledge among rsync developers that a daemon rereads its config multiple times, with no warnings when it changes:
#409 (comment)
I exercised this behaviour by creating a temporary, scruffy rsync daemon, and attempting to configure it with a bash process substitution.
There is currently no warning the manual. This request contains my proposed wording.
As well or instead, people might prefer a code change, so that rsync daemons read the whole config and report warnings in the log when it changes. The code for that change is beyond me.
My configuration details and test case:
$ rsync --version rsync version 3.4.1 protocol version 32 ... $ uname -a Linux debian 6.12.107+deb13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.107-1 (2026-08-29) x86_64 GNU/LinuxI was writing a scruffy, temporary rsync daemon, and tried to have only the shellscript that launched it: