Repository navigation
Update TLS, QUIC, and tokio crates for RustSec advisories - #24
Merged
Merged
Conversation
cargo audit failed with 11 vulnerabilities in quinn-proto, rustls, rustls-webpki, and webpki-roots, and cargo deny failed on the unsound tokio AsyncFd constructors (RUSTSEC-2026-0386). Move each to its patched release, and replace the unsound event-listener 5.4.1 and the yanked chacha20 0.10.1. Cargo.lock only.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
verifyjob fails on every PR, e.g. Dependabot #23 (run).cargo auditreports 11 vulnerabilities. They're already onmain; #23 only bumps unrelated crates. Once those are fixed,cargo denyalso fails on an unsoundtokioadvisory.Changes (
Cargo.lockonly)quinn-protorustlsDebugleaking secrets, ECH-rejection data leak, Brotli 1 GiB allocation, ServerHello downgrade)rustls-webpkiwebpki-rootstokioAsyncFdconstructors;cargo denyerror)event-listenerchacha20concurrent-queuedrops out, sinceevent-listener5.4.2 no longer depends on it. No other package changes.Testing (Rust 1.88.0, the pinned toolchain; same commands as
verify)cargo fmt --all -- --check: okcargo clippy --all-targets --all-features -- -D warnings: okcargo test --all-targets --all-features: 78 + 9 + 5 + 5 + 3 passedcargo audit: 0 vulnerabilities, 0 warnings (was 11 vulnerabilities + 2 warnings)cargo deny check … advisories bans licenses sources:advisories ok, bans ok, licenses ok, sources okOnce this merges, Dependabot #23 needs a rebase (
@dependabot rebase).deny.tomlstill ignores RUSTSEC-2026-0002 and RUSTSEC-2026-0253 forlruvia ratatui.cargo denynow reports them as "advisory not encountered", so those two ignores can be dropped in a follow-up.