Repository navigation
Expose analytics cache freshness revalidation failures and pressure - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing cache hit totals hide stale dashboard answers and failed background revalidation. Extend the existing query_request_cache event with fresh/stale hit counts, one failure per shared background refresh, oversized-cache-bypass counts and numeric cache entry/byte/in-flight snapshots. Preserve existing counters and exclude expected background cancellation from failures. Semantic keys, user/tenant IDs and query content remain in memory only.
Validation: 31 focused cache/API/privacy tests and production build/typecheck. Tests distinguish fresh and stale responses, deduplicate shared background failures, cover oversized bypass and expected cancellation, verify pressure snapshots, and pass summaries through the production RUM sanitizer. Standalone main-based PR; #117 enables telemetry in standard released images.
Combined validation: all six frontend health PRs merge together without conflicts. The integrated suite passes 645 tests in 107 files and the production build/typecheck. A production-bundle Chrome smoke verified runtime opt-in, actual package version/environment, API/body events, failed lazy-route navigation, investigation completion/malformed-event counts and browser offline/recovery duration. Eleven custom event types arrived through the SDK and production privacy scrubber without query text or user identifiers in their attributes.