Repository navigation
Conversation
…sory exceptions jsonwebtoken 12 and opensaml 0.8 / bergshamra 0.12 move the RustCrypto stack to p256/p384 0.14 (crypto-bigint 0.7) and rsa 0.10. That clears RUSTSEC-2026-0387 and RUSTSEC-2023-0071, so both come out of deny.toml and .cargo/audit.toml. EncodingKey::from_secret is fallible in jsonwebtoken 12; the one test that builds an HMAC key unwraps it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last two RustSec exceptions by updating the crates that pulled in the old RustCrypto stack.
Why both crates
RUSTSEC-2026-0387(crypto-bigint 0.5) andRUSTSEC-2023-0071(rsa 0.9) came in through two paths: jsonwebtoken (OIDC and license JWTs) and opensaml → bergshamra (SAML signature checks). Updating only jsonwebtoken leaves both advisories in place through SAML.After the update, the tree has only crypto-bigint 0.7, elliptic-curve 0.14 and rsa 0.10.
deny.tomlhasignore = [], and.cargo/audit.tomlkeeps only the two unmaintained-crate entries (bincode, unsafe-libyaml).Behavior
EncodingKey::from_secretreturning aResult(12.0 rejects empty HMAC keys). That's in one SSO test. Production code only buildsDecodingKeys. 12.0 also rejects tokens with unknowncritheader extensions.opensaml::crypto::verify::verify_signature. In 0.8 that function still verifies under theAllowProviderSupportedForCompatibilityprofile, notRecommended, so IdPs that sign with older algorithms keep working. saml-rs 0.4 through 0.8 add stricter XML and signature-coverage checks. The existing SAML tests insrc/saml.rspass unchanged: a signed response verifies and a tampered one is rejected, a missing or bogus signature fails closed, and the audience, expiry, issuer and request-correlation checks reject bad assertions.Checked locally (toolchain 1.89.0)
cargo audit: no vulnerabilities.cargo deny check: advisories, bans, licenses and sources ok.cargo fmt --checkandcargo clippy --all-targets --all-features -- -D clippy::correctness -D clippy::suspicious: clean.cargo test --all-targets --all-features: 862 passed, 0 failed.Worth a manual SAML and OIDC login against a real IdP before the next release.