Conversation
Cores and MAC types already zeroize on drop, but the compile-time output-size wrappers (Blake2b512 and the other buffer_ct_variable types) did not implement the marker trait.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #912.
digest::buffer_ct_variable!builds the public wrappers (Blake2b512,Groestl512,Kupyna512, and the other compile-time output-size types) but does not implementZeroizeOnDrop.buffer_fixed!already does. The innercore/bufferfields do implement it when thezeroizefeature is on, so the wrappers already zeroize on drop — they just do not advertise the marker trait.This adds the same empty marker impl used by
buffer_fixed!, locally, until digest emits it from the macro (same pattern as the nearbyCustomizedInitimpls).Tests
cargo test -p blake2 --features zeroize --lib wrappers_impl_zeroize_on_dropcargo test -p groestl --features zeroize --lib wrappers_impl_zeroize_on_dropcargo test -p kupyna --features zeroize --lib wrappers_impl_zeroize_on_dropcargo test -p blake2 --offlinecargo test -p blake2 --features zeroize --offlinecargo test -p blake2 --all-features --offlinecargo test -p groestl --offlinecargo test -p groestl --features zeroize --offlinecargo test -p kupyna --offlinecargo test -p kupyna --features zeroize --offline