Skip to content

Classify JavaScript in ui/ as UI behavior - #91

Merged
JamieW105 merged 2 commits into
mainfrom
feat/ui-javascript-folder
Nov 9, 2026
Merged

JamieW105 merged 2 commits into
mainfrom
feat/ui-javascript-folder

Conversation

@JamieW105

@JamieW105 JamieW105 commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

JavaScript .js and .mjs files under the project’s top-level ui/ directory now default to the Web/UI category, including nested folders. Existing registrations retain their IDs and attachments when adopting the category, and registered moves into or out of ui/ update it.

Standalone UI JavaScript uses the bundled sandbox and retains scene queries and gameplay signals. Source loading avoids HTML parsing for JavaScript, and hot reload preserves its source type. This does not add DOM rendering or automatic execution without an attachment. Engine documentation and generated agent authoring guidance describe setup and communication. The lockfile uses async-executor 1.14.1 to replace the yanked 1.14.0 release.

Validation:

  • Full Linux and Windows engine CI: passed, including Clippy, workspace tests, rendered viewport checks and application smoke tests.
  • Language adapter conformance and browser game export: passed.
  • Dependency security/licenses, secret scan and workflow syntax: passed.
  • Fresh Windows installer build and packaged Setup/toolchain tests: passed; the workflow uploaded the windows-installer artifact.
  • Local scripting tests: 56 passed. UI signal delivery, scene reads and hot reload passed for .js and nested .mjs, including after the dependency update.
  • Existing linked Web script and hot reload tests, formatting and diff checks: passed.
  • Local dependency policy checks for the workspace and standalone Luau host: passed.

Agent guidance was updated to describe UI folder detection, required attachments, state sharing and gameplay signals. No additional plugin changes are needed for the dependency update.

@JamieW105
JamieW105 marked this pull request as ready for review November 9, 2026 05:07
@JamieW105
JamieW105 merged commit 08f53c3 into main Nov 9, 2026
9 checks passed
@github-actions
github-actions Bot deleted the feat/ui-javascript-folder branch November 9, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants