Repository navigation

Light and overlay fixes [`develop`] [4/4] - #922

Open

PetrilloAtWork wants to merge 168 commits into

SBNSoftware:developfrom

PetrilloAtWork:feature/pmtsim_gainDevelop

Commits on Aug 20, 2026
- fix sim label for PDFastSim
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  89b5994
- detsim_opdetonly_icarus.fcl: simulate only optical detector digitization
  PetrilloAtWork
  committed
  aa808ae
- Changed determination of the end of single photoelectron response template
  PetrilloAtWork
  committed
  5059f0e
- Updated `FastGaussianNoiseGeneratorAlg` documentation
  PetrilloAtWork
  committed
  9b1acce
- SelectCathodeCrossingGenParticles: selects generated events with particles that might cross cathode
  PetrilloAtWork
  committed
  ad8a87e
Commits on Aug 21, 2026
- make MC2-var4 tune standard
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  980fa3a
- simulate pmt timing delays in mc
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  5d226d7
- disable pmt mc noise for overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4c90bfd
- add ophituncorrected + ophit flow for mc
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  75a1387
- update stage0 flow for overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  90185a6
- small fix
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b6e85fd
- prelimanary reco gain tuning
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3a21af7
- add SPRRun3, make SPRRun2 default
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  c8b658b
- nullify flash calibration
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  835ff1b
- add run3 opdet tune, make run2 default
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e2b2a6a
- change run3->run4, update gain
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  6ae6370
- add run4 detsim fhicls
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  1c4ad07
- first attempt at detsim reprocessing fhicl
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4aa117e
- fix typo
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  38358e2
- Trigger simulation modules: support input tag with process name
  PetrilloAtWork
  committed
  227d4ff
- Apply suggestions from GIT Copilot code review
  
  PetrilloAtWork
  and
  Copilot
  committed
  3790b68
- fix to detsim reprocessing
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  39a7a59
- reprocessing opdetonly overlay fhicl
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b7b6d5e
- leave default tags
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e4ae307
- add initial recalibrator module
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  dc24177
- fix compilation for recalibrator
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b136e13
- link online corrections service to recalibrator
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  9df1310
- link locally-provided old timing corrections
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b76b224
- fix timing recalibration
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  caf2544
- remove custom config, fixed indentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4d9da25
- chop off flat waveform tail in overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  91b1df1
- restore legacy defaults for backward compatibility
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a4b8422
- fixed documentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  bdaa0f8
- add opdetonly MCstage0 fhicls for reprocessing
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  45dd3cd
- fix stage0 reprocessing fhicls
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  496e3cc
- adjust stage1 compatibility
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  5beee5e
- add data reprocessing fhicl(s)
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  94c5088
- update file names
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ad179a5
- ICARUSFlashFinder: added Doxygen-style header
  PetrilloAtWork
  committed
  2939e85
- ICARUSFlashFinder: turned into shared module
  PetrilloAtWork
  committed
  c7bb7c5
- ICARUSFlashFinder: FHiCL configuration validation
  PetrilloAtWork
  committed
  82f1ca5
- ICARUSFlashFinder: code updates
  PetrilloAtWork
  committed
  da32908
- ICARUSFlashFinder: removed hit recalibration (PECalib)
  PetrilloAtWork
  committed
  1b0003f
- dump_opflashes_icarus.fcl: dump reconstructed flashes on text file
  PetrilloAtWork
  committed
  dbc2ffe
- Adopting corrections from GitHub Copilot
  PetrilloAtWork
  committed
  a8353f1
- Removed obsolete icarus_flashcalib.fcl
  PetrilloAtWork
  committed
  6ccfdf8
- tentative debug tree
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  57ca8b9
- tweaks for success build
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  703963d
- move to other loop
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  475557d
- save debug only with photons
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  6ddc1cd
- store photon start position in debug
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  971ca7c
- remove old variables
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  67b5e9f
- remove forgotten variable
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ae74366
- first commit, compiles and does nothing
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  4609a47
- changed namespaces
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  d2deb20
- basic struct/map for holding spe areas
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  da458ea
- working version getting area from database and initial database file
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  daa2fb0
- updated tags in db file
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  17c05a9
- add fcl file for debugging spe area service
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  fc373f9
- PMT calibration service code review
  PetrilloAtWork
  committed
  808d6e5
- update pmt calibration service provider
  
  Michael Carrigan
  authored and
  PetrilloAtWork
  committed
  b38a5cc
- removed db file + copilot suggestions
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  fca6bad
- interface SPEArea DB with ophit recalibrator
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  46b05ae
- fix cout of current areatag
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  be1c00a
- rework stage0 optical workflow for data, mc, overlay
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d0dc424
- simulate pmt timing delays only for overlay flow
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  fea7374
- remove ophituncurrected from legacy mc flow
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  4d3ac06
- tune mcophit
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  61ed4aa
- make applytimingdelays explicit
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  034759b
- add run3/4 stage0 overlay light tunes
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  eba271d
- remove useless while loop
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  06c621e
- fix-up comment
  
  mvicenzi
  and
  PetrilloAtWork
  committed
  10531d4
- use microseconds, pass service as pointer not reference
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  1d03225
- fixes + indentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  8b09af5
- minor fixes
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b7e4aac
- add documentation in fhicls
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  51c806e
- use mf:errorlog
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  2237942
- improve documentation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  f9dc193
- more documentation please
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  30469f1
- augment gain db service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d457494
- add gain service provider interface
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3426a89
- fix linking for db interface
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  213f412
- update speareas database tag
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a68acd8
- add pmt channel status service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  16ed4f7
- tie up the service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  a6a8814
- fix linking
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  1f8be5c
- change kOn to kGood
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  163a15b
- use channel status service in pmtsim
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  7f7f5b0
- update fcls for legacy vs overlay flow
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  1453393
- switch reco to local entry point
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  832c051
- fix sharing factory with ped algos
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e2a1441
- fix standard calibrator + add channel status service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3f174d8
- remove conflicting defaults
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e89820c
- remove mcophit from mc-overlays
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  f51bcef
- never hold service pointers, you fool
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  994ce67
- expose integral and bias from sampled waveform tool
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  742f4b3
- plug in db gain and spread in simulation
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  47b81f4
- fix variable name
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  53fa682
- keep database use false for default non-overlay MC
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  33988a2
- add forgotten service
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ba7c1ee
- improve prints
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  b1574bc
- better printing
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  15da565
- apply integral definition bias
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  77edef3
- update db tag
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  22fe186
- update variable names
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  01a7b9b
- TailNSigmaThreshold is wrong, should be TailNSigma
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  0e1ab8f
- re-tune flash algo for new SPEAreas to match past performance
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  1b7c19c
- add ophit integral to flashana tree
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  3c11db1
- add run number ovverides to PMT db services
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  81b15ba
- introducing vertical track flash/wf module
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  71488cc
- make waveforms optional, add total PE per pmt
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ac354dd
- update transit time
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  09a97a6
- TriggerSimulationOnGates: added fixed configurable trigger delay
  PetrilloAtWork
  committed
  5966cbd
- Update after TimeIntervalConfig breaking change
  PetrilloAtWork
  committed
  8225320
- SimPMTIcarus: reworked internals
  PetrilloAtWork
  committed
  17f6784
- SimPMTIcarus: produce baseline data products and associations
  PetrilloAtWork
  committed
  9411382
- PMTsimulationAlg: changed waveform superposition rounding, and default baseline
  PetrilloAtWork
  committed
  1e0e978
- Maintenance commit
  PetrilloAtWork
  committed
  5fafca1
- OverlayPMTwaveforms: dedicated PMT waveform overlay module
  PetrilloAtWork
  committed
  67d81ce
- Simulation timescale changed to the "shifted" time
  PetrilloAtWork
  committed
  97769cd
- Trigger configuration maintenance
  PetrilloAtWork
  committed
  aeefc3e
- MC trigger simulation baselines now read from a data product.
  PetrilloAtWork
  committed
  e994d97
- Trigger simulation gate now refers to simulation time instead of beam gate time
  PetrilloAtWork
  committed
  813ca8b
- TriggerSimulationOnGates: fix beam gate output
  PetrilloAtWork
  committed
  a4a8342
- Added trigger time delay to the trigger simulation
  PetrilloAtWork
  committed
  a909aa8
- Filtering disables in Stage0 MC to allow for fast cloning
  PetrilloAtWork
  committed
  69f7f39
- Retuned trigger-flash delay in TPC-PMT matching
  PetrilloAtWork
  committed
  8d7623c
- Tuned beam gates to Run2 data
  PetrilloAtWork
  committed
  7125e06
- Using SBN (shared) GENIE configuration for BNB and NuMI
  PetrilloAtWork
  committed
  35cbfb2
- Tuned BNB gate again (after enabling neutrino propagation time)
  PetrilloAtWork
  committed
  568cfcc
- manageDataRunDefinitions.py version 1.1
  PetrilloAtWork
  committed
  68796ae
- Removed configuration override used in development
  PetrilloAtWork
  committed
  14ea0d8
- Indentation fix
  PetrilloAtWork
  committed
  e464b54
- TriggerSimulationOnGates module: fixed trigger timestamp encoding
  PetrilloAtWork
  committed
  99a40bc
- TriggerSimulationOnGates: timestamp can be imported from a data product
  PetrilloAtWork
  committed
  aa464e9
- TriggerSimulationOnGates module: minor bug fixes
  PetrilloAtWork
  committed
  5c52f8d
- TriggerSimulationOnGates module: documentation fixes
  PetrilloAtWork
  committed
  0a702eb
- CRT hit reconstruction: add time offset only in data
  PetrilloAtWork
  committed
  4bd36d0
- CRT hit reconstruction: ignore trigger timestamp for simulation
  PetrilloAtWork
  committed
  f4db554
- "Answered" Tracy Usher's questions on Stage0 workflow
  PetrilloAtWork
  committed
  48d6858
- MC Stage0 CRT/PMT matching uses shifted trigger to determine in-beamness
  PetrilloAtWork
  committed
  d9c6443
- Code maintenance
  PetrilloAtWork
  committed
  6d7bf88
- RebuildShiftedTrigger: makeup module for reprocessing Monte Carlo samples
  PetrilloAtWork
  committed
  ae56eef
- Minor fix to simulation workflow
  PetrilloAtWork
  committed
  25a4e9b
- FixBeamGateInfo: changed gate selection
  PetrilloAtWork
  committed
  f45c0c8
- OverlayPMTwaveforms: more information when baseline not found
  PetrilloAtWork
  committed
  e09a458
- MC reprocessing updated to reflect changes in workflow
  PetrilloAtWork
  committed
  8461fa5
- DataProductReader: prints available data products and their tags
  PetrilloAtWork
  committed
  a8fd2a5
- Apply suggestions from code review
  
  committed
  397510d
- Custom changes after automated review report
  PetrilloAtWork
  committed
  0a08c23
- Fixed Run4 reprocessing misfiring FHiCL override
  
  PetrilloAtWork
  and
  Copilot
  committed
  a29f754
- change default pmt channel status to off
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d832906
- detsim_opdetonly_icarus_overlay_reprocessing_run2.fcl: fixed time reference
  PetrilloAtWork
  committed
  3b11b44
- Updated CAFMaker configuration (applies shift to beam gate time)
  PetrilloAtWork
  committed
  0fb788e
- icarus_data version dependency bump: v10_20_04
  PetrilloAtWork
  committed
  415a63b
- bugfix: do not recalibrate hits flagged as bad in status db
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  0e5e766
- include initial tail suppression
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  42bdce0
- fix casting
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  e70354f
- move printout
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  06e8c51
- fix time constant
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  0c626c4
- test distance dependent survival
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  ff4af3c
- update run2 tailsupp and survival distance tune
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  d1294b5
- improve documentation, clarify currently missing run4 tune
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  80d3cf1
- Update icaruscode/PMT/Algorithms/PMTsimulationAlg.cxx
  
  mvicenzi
  and
  PetrilloAtWork
  committed
  a5bee55
- Apply suggestion from @PetrilloAtWork
  
  mvicenzi
  and
  PetrilloAtWork
  committed
  b559459
- switch to fhicl::OptionalTable + print DistanceSurvival settings as well
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  40c301d
- add reprocessing stage0 fhicls with no DB use
  
  mvicenzi
  authored and
  PetrilloAtWork
  committed
  6d3d05c
Commits on Aug 31, 2026
- Merge branch 'develop' into feature/pmtsim_gainDevelop
  jas1005
  authored
  326e709

Commits

Commits on Aug 20, 2026

Commits on Aug 21, 2026