Repository navigation
Update and harden GitHub Actions workflows - #418
Merged
Merged
Conversation
The new Windows runner images ship Visual Studio 2026, which requires CMake 4.2 or later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the CSFML workflows in line with what we did for SFML. The Windows jobs move to the
windows-2025-vs2026andwindows-11-vs2026-armimages and build with the Visual Studio 2026 generator, which requires CMake 4.2, as such the Windows jobs now pull that version. Additionally, all actions are bumped to their latest major version.The second commit hardens the workflows the same way as SFML:
permissions: {}on the workflow level,persist-credentials: falseon every checkout, and step outputs are passed throughenvinstead of being interpolated into scripts.How to test this PR?
CI should succeed. The NuGet and release workflows don't run for PRs, only on master, tags or manual dispatch, so those are best checked with a manual run on this branch.