Repository navigation
feat(examples): demonstrate semantic input bindings - #65
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyA/KeyD/SpaceandArrowLeft/ArrowRight/Enterbindings routing to stablemoveLeft,moveRight, andconfirmsemantic actions through the existingcreateActionMapAPI.Source evidence
Acceptance scope and boundary
The smoke check exercises both binding sets with the same
moveLeftaction, checks aconfirmcommand, and verifies unknown actions and duplicate source IDs are rejected without creating replay output. Everything runs on the dry-run adapter without physical hardware.The docs state that OpenController does not capture keyboard or physical gamepad input, change OS/Steam remapping, or provide a settings UI or persistent profile. Dry-run results establish OpenController command/state behavior only; they make no host, browser, Steam, device, or game input claim.
Validation
bun run check:dry-run-examples— passed (dry-run example checks and MCP controller smoke checks).bun run typecheck— passed.bun run lint— passed (Biome checked 157 files).git diff --check— passed.bun run examples/basic-dry-run/ai-agent-integration.ts— passed; both binding-set runs completed on dry-run.Closes #61