Repository navigation
test: give the replaced-widget action two minutes on a busy runner - #795
Merged
Merged
Conversation
completedActionCannotRestartAReplacedWidget holds a widget action until the test has reloaded the configuration and seen the replacement widget's output. The widget set no timeout, so the action got the default 10 seconds, and on CI the main-actor turns in between took longer: the command was killed and store.actionErrors kept the timeout (PR #789's run took 75 seconds). The widget now sets a 120-second timeout, as #656 gave the other held commands in this file. A probe that held the main actor for 11 seconds after the action started failed the test the same way before this change and passed after it. Fixes #790
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
completedActionCannotRestartAReplacedWidgetfailed CI on #789 (#790). It holds a widget action until it has reloaded the configuration and seen the replacement widget's output. The widget set notimeout, so the action got the default 10 seconds. On a busy runner the main-actor turns in between took longer: the command was killed andstore.actionErrorskept "Command timed out after 10.0 seconds." The test took 75 seconds there, against well under one alone.Fixes #790
Changes
The test's widget sets
"timeout": 120, as #656 gave the other held commands inScriptEventTests.store.stop()still ends the action if the test fails early.Testing
sleepon the main actor). Without this change the test failed the way CI did (store.actionErrors.isEmpty); with it, it passed. The probe isn't committed.ScriptEventTestspassed without the probe.Merging
Any merge method: one commit.
Claude Opus 5.5 via Claude Code