Skip to content

test: give the replaced-widget action two minutes on a busy runner - #795

Merged
M4n0x merged 1 commit into
mainfrom
test/790-replaced-widget-timeout
Nov 17, 2026
Merged

M4n0x merged 1 commit into
mainfrom
test/790-replaced-widget-timeout

Conversation

@M4n0x

@M4n0x M4n0x commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Problem

completedActionCannotRestartAReplacedWidget failed CI on #789 (#790). It holds a widget action until it has reloaded the configuration and seen the replacement widget's output. The widget set no timeout, so the action got the default 10 seconds. On a busy runner the main-actor turns in between took longer: the command was killed and store.actionErrors kept "Command timed out after 10.0 seconds." The test took 75 seconds there, against well under one alone.

Fixes #790

Changes

The test's widget sets "timeout": 120, as #656 gave the other held commands in ScriptEventTests. store.stop() still ends the action if the test fails early.

Testing

  • A temporary probe held the main actor for 11 seconds right after the action started (sleep on the main actor). Without this change the test failed the way CI did (store.actionErrors.isEmpty); with it, it passed. The probe isn't committed.
  • All 11 tests in ScriptEventTests passed without the probe.

Merging

Any merge method: one commit.

Claude Opus 5.5 via Claude Code

completedActionCannotRestartAReplacedWidget holds a widget action until the test has reloaded the
configuration and seen the replacement widget's output. The widget set no timeout, so the action got
the default 10 seconds, and on CI the main-actor turns in between took longer: the command was
killed and store.actionErrors kept the timeout (PR #789's run took 75 seconds).

The widget now sets a 120-second timeout, as #656 gave the other held commands in this file. A
probe that held the main actor for 11 seconds after the action started failed the test the same
way before this change and passed after it.

Fixes #790
@M4n0x
M4n0x requested a review from Seb-GRAF as a code owner November 17, 2026 21:25

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@M4n0x
M4n0x merged commit fd3d382 into main Nov 17, 2026
21 checks passed
@M4n0x
M4n0x deleted the test/790-replaced-widget-timeout branch November 17, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

completedActionCannotRestartAReplacedWidget times out on a busy CI runner

1 participant