Repository navigation
M24, second part: display names and last login - #60
Merged
Merged
Conversation
Accounts get an optional display name and a last login, kept in a new StaffProfiles table and shown to admins only. The activity log keeps the account's email as at the time. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Seb H. <138793908+SebHenn@users.noreply.github.com>
The test fails now and then on CI only, where poppler is installed, and the cause is not known yet. A failure now says what was stored. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Seb H. <138793908+SebHenn@users.noreply.github.com>
A long random word at 24 pt ran past the page edge, and poppler leaves out what falls outside the page, so the last letter was missing and the PDF search test failed now and then. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Seb H. <138793908+SebHenn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accounts get an optional display name and a last login (new
StaffProfilestable, migration included). Both are shown to admins on the Accounts pages only; not public, not exported, not in the activity log (which keeps the email as at the time). Name changes are logged. Login pages record the last login after a successful password, authenticator or recovery-code login.Tested locally: full suite (496 passed, 5 skipped PDF/scale), browser tests 206 passed, privacy review fixes applied, gitleaks clean. Not tested: the authenticator/recovery-code login paths' last-login recording has no dedicated test.
🤖 Generated with Claude Code