Skip to content

feat(chart): add recipe markers and the marker lock (#160) - #161

Merged
mrcsin merged 1 commit into
masterfrom
recipe-markers-on-chart
Oct 28, 2026
Merged

mrcsin merged 1 commit into
masterfrom
recipe-markers-on-chart

Conversation

@mrcsin

@mrcsin mrcsin commented Oct 28, 2026

Copy link
Copy Markdown
Member

Problem

The SCADA inserts recipe start, end and interruption markers into semiplot_markers, and SemiBase v0.7.0 added kind and locked to the table (Semiteq/SemiBase#21). The chart read neither column: a recipe marker looked like the operator's own, and a double click or a stray drag could delete or move a recipe boundary.

What changed

  • The marker read carries kind (MarkerKind) and locked; one new write, SET locked, goes through the store, MarkerSync and ChartMarkers.ToggleLockAsync.
  • A locked marker routes to pan-or-pick (ChartPressRegion.LockedMarker): no drag, no double-click delete. The marker menu still renames and deletes it and gains Lock / Unlock.
  • A recipe marker draws in AppRecipeMarkerLineBrush; a locked line draws solid.
  • View -> Recipe markers hides recipe markers per window. MarkerSet keeps All and a cached ShownMarkers, which the lines, readings, minimap ticks and hit test read.
  • SemiBase v0.7.0 is the minimum; docs, AGENTS.md and readme.md updated.

The database does not enforce locked; only the chart's gestures honour it. The export range picked by markers is the second part of #160 and is not in this PR.

Part of #160.

Verification

  • Unit suite 2445/2445; MarkerStoreTests 26/26 against SemiBase v0.7.0; the whole integration project 210/210 before the review fixes.
  • dotnet format --verify-no-changes and terse pass.
  • Manual check on the stand: a recipe marker inserted as kind = 1, locked = true draws solid in the recipe colour, ignores drag and double click, unlocks from the menu, and hides with View -> Recipe markers.
Per-task commits before collapse
6c02275 docs(plans): record the recipe markers run (#160)
fb69271 docs(markers): trim the marker channel summary (#160)
bf49847 refactor(markers): address smells review (#160)
4e1f0b0 fix(markers): address review findings (#160)
8c0fd28 docs(markers): describe recipe markers and the lock (#160)
bbfe8a0 docs(plans): record recipe marker acceptance run (#160)
38c13b7 feat(chart): hide recipe markers per window (#160)
267c3f0 feat(chart): draw marker kind and lock on the line (#160)
97ba493 feat(chart): add Lock and Unlock to the marker menu (#160)
1c1be9b feat(chart): let a locked marker ignore drag and delete (#160)
c2af857 feat(markers): carry the lock write to the chart (#160)
105a0ad feat(markers): read marker kind and lock (#160)
9370cec docs(plans): add recipe markers plan (#160)

🤖 Generated with Claude Code

The SCADA now inserts a marker at each recipe's start, end and
interruption into semiplot_markers, and SemiBase v0.7.0 gives the table
a kind and a locked column. The chart read neither: a recipe marker
looked like the operator's own, and a double click or a stray drag could
delete or move a recipe boundary that the CSV export is to be cut by.

The marker read now carries the kind and the lock, and one new write
stores the lock. A locked marker ignores the drag and the double click,
since its press region routes to pan-or-pick; the marker menu still
renames and deletes it and gains Lock / Unlock. A recipe marker draws in
its own palette colour and a locked one draws solid. View -> Recipe
markers hides the recipe markers in one window: MarkerSet keeps every
marker and a cached shown subset, which the lines, the readings, the
minimap ticks and the hit test read. The database does not enforce the
lock, so only the chart's gestures honour it.

SemiBase v0.7.0 is now the minimum: against v0.6.0 every marker read
fails as ShapeUnexpected. The docs record the new columns, the five
marker writes, the gesture routing and the scada_writer INSERT grant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mrcsin
mrcsin marked this pull request as ready for review October 28, 2026 13:26
@mrcsin
mrcsin merged commit ace2c58 into master Oct 28, 2026
2 checks passed
@mrcsin
mrcsin deleted the recipe-markers-on-chart branch October 28, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant