Repository navigation
feat(chart): add recipe markers and the marker lock (#160) - #161
Merged
Merged
Conversation
The SCADA now inserts a marker at each recipe's start, end and interruption into semiplot_markers, and SemiBase v0.7.0 gives the table a kind and a locked column. The chart read neither: a recipe marker looked like the operator's own, and a double click or a stray drag could delete or move a recipe boundary that the CSV export is to be cut by. The marker read now carries the kind and the lock, and one new write stores the lock. A locked marker ignores the drag and the double click, since its press region routes to pan-or-pick; the marker menu still renames and deletes it and gains Lock / Unlock. A recipe marker draws in its own palette colour and a locked one draws solid. View -> Recipe markers hides the recipe markers in one window: MarkerSet keeps every marker and a cached shown subset, which the lines, the readings, the minimap ticks and the hit test read. The database does not enforce the lock, so only the chart's gestures honour it. SemiBase v0.7.0 is now the minimum: against v0.6.0 every marker read fails as ShapeUnexpected. The docs record the new columns, the five marker writes, the gesture routing and the scada_writer INSERT grant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SCADA inserts recipe start, end and interruption markers into
semiplot_markers, and SemiBase v0.7.0 addedkindandlockedto the table (Semiteq/SemiBase#21). The chart read neither column: a recipe marker looked like the operator's own, and a double click or a stray drag could delete or move a recipe boundary.What changed
kind(MarkerKind) andlocked; one new write,SET locked, goes through the store,MarkerSyncandChartMarkers.ToggleLockAsync.ChartPressRegion.LockedMarker): no drag, no double-click delete. The marker menu still renames and deletes it and gainsLock/Unlock.AppRecipeMarkerLineBrush; a locked line draws solid.View->Recipe markershides recipe markers per window.MarkerSetkeepsAlland a cachedShownMarkers, which the lines, readings, minimap ticks and hit test read.AGENTS.mdandreadme.mdupdated.The database does not enforce
locked; only the chart's gestures honour it. The export range picked by markers is the second part of #160 and is not in this PR.Part of #160.
Verification
MarkerStoreTests26/26 against SemiBase v0.7.0; the whole integration project 210/210 before the review fixes.dotnet format --verify-no-changesandtersepass.kind = 1, locked = truedraws solid in the recipe colour, ignores drag and double click, unlocks from the menu, and hides withView->Recipe markers.Per-task commits before collapse
🤖 Generated with Claude Code