Skip to content

feat(export): pick a range by stored markers (#160) - #162

Merged
mrcsin merged 1 commit into
masterfrom
export-range-by-markers
Oct 29, 2026
Merged

mrcsin merged 1 commit into
masterfrom
export-range-by-markers

Conversation

@mrcsin

@mrcsin mrcsin commented Oct 29, 2026

Copy link
Copy Markdown
Member

Problem

Exporting one recipe meant reading its start and end off the chart and typing both into the export window. The SCADA now stores recipe markers, but the export could use neither them nor the operator's markers.

What changed

  • Each range edge has a date line and a line with its time and a marker box.
  • The start box offers user and recipe-start markers of the selected day; the end box offers user, recipe-end and interrupted markers strictly after the start.
  • Choosing a marker writes its date and time. A hand edit or a date change releases it.
  • A labelled start marker supplies the suggested CSV file name.
  • Stable marker collections keep ComboBox selections across updates. The end is rounded to the next second because export slices exclude their end bound.
  • Documentation covers the controls, rounding and file-name rules.

Closes #160.

Verification

  • Unit suite: 2517 passed. Integration suite: 211 passed after the layout change; the final fixes touch the same UI code.
  • dotnet format --verify-no-changes and terse pass.
  • Two final read-only reviews of a010848..HEAD found no critical or major issues.
  • Manual stand check passed after the final fixes, including repeated start/end/start selection without blank marker boxes.
Per-task commits before collapse
9425a25 docs(plans): record the export by markers run (#160)
4737a15 fix(export): place a last-second end marker after the pick (#160)
b5ed3b6 fix(export): keep a box's marker across list updates (#160)
a010848 fix(export): keep the marker boxes consistent (#160)
ad4bc62 docs(export): drop restating comments (#160)
41010f1 feat(export): pick a range edge's marker from a list (#160)
80bd1f7 refactor(export): address smells review (#160)
6f650f7 fix(export): address review findings (#160)
5d2cf59 docs(export): describe the export by markers (#160)
54a38c3 docs(plans): verify export by markers (#160)
289d25b feat(export): name the file from the start marker (#160)
106afb8 feat(export): add the marker buttons to the window (#160)
6718afd feat(export): list a range edge's markers (#160)
ca8cc0f feat(export): snapshot the markers into the export (#160)
f3a0772 docs(plans): add export range by markers plan (#160)

🤖 Generated with Claude Code

Exporting one recipe meant reading its start and end off the chart and
typing both into the export window. The SCADA now stores recipe markers,
but the export could use neither them nor the operator's markers.

Each range edge now has a date line and a line with its time and a marker
box. The start box offers user and recipe-start markers of the selected
day; the end box offers user, recipe-end and interrupted markers strictly
after the start. Choosing a marker writes its date and time, while a hand
edit or a date change releases it. A labelled start marker also supplies
the suggested CSV file name.

The marker lists keep stable collection instances so ComboBox selections
survive updates. The end is rounded to the next second because export
slices exclude their end bound. Documentation covers the new controls,
rounding and file-name rules.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@mrcsin
mrcsin marked this pull request as ready for review October 29, 2026 11:33
@mrcsin
mrcsin merged commit e7f12c7 into master Oct 29, 2026
2 checks passed
@mrcsin
mrcsin deleted the export-range-by-markers branch October 29, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export: pick a range by recipe markers

1 participant