Repository navigation
feat(legend): fold pen groups in the sidebar (#139) - #163
Merged
Merged
Conversation
With many groups the sidebar ran past the screen and the watched pens scrolled out of view. A group's own column, such as the folded_on_start flag SemiBase#18 added, had no route to the sidebar: the chart read normalised pens with group-name strings, the editor read the stored catalogue separately, and the sync compared pens only. The catalogue is now one provider read, QueryCatalogueAsync, that returns the stored catalogue and the normalised pens of the same rows, both statements in one REPEATABLE READ snapshot under the 5 s bound. PenCatalogueSync emits a read whenever CatalogueRead.Matches finds any stored pen or group changed, so a change the normalisation hides and a group-only change both reach the window. The sidebar builds its headers from the stored groups. This is the database groundwork of #140; the editor that follows reads has its own plan. Each group header gets a ghost chevron that folds its rows for the session. The fold is keyed by header name, seeded from folded_on_start the first time a name is drawn, and survives every rebuild; a pick on the chart unfolds a pen folded away. The pen editor edits folded_on_start on the selected group. The panel button is renamed after the values it hides, a fold-all button joins it, both turn into icons below a 272 px panel, and the View menu gains the values toggle, fold-all, and show or hide all pens, the last two through one batch chart method that keeps the picked pen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With many groups the sidebar runs past the screen and the watched pens scroll out of view. A group's own column, such as
semiplot_groups.folded_on_start(Semiteq/SemiBase#18), had no route to the sidebar: the chart read normalised pens with group-name strings, the editor read the stored catalogue on its own, and the sync compared pens only.What changed
IDataProvider.QueryCatalogueAsync, returnsCatalogueRead: the stored catalogue and the normalised pens of the same rows, both statements in oneREPEATABLE READsnapshot under the 5 s bound.PenCatalogueSync.Changesemits a read wheneverCatalogueRead.Matchesfinds a stored pen or group changed. The sidebar builds headers from the stored groups. This is the database groundwork of Sync: open editors follow values stored elsewhere #140; the editor that follows reads is planned separately indocs/plans/20261030-editor-follows-reads.md.folded_on_startthe first time a name is drawn, and survive every rebuild. A pick on the chart unfolds a pen folded away; the window's own first pen choice unfolds nothing.folded_on_starton the selected group.Скрыть значения/Показать значенияafter the columns it hides. A fold-all button sits beside it. Both turn into icons below a 272 px panel.ВидgainsЗначения в панели, fold-all,Показать все перьяandСкрыть все перья. Show and hide all go through one chart method,SetAllPensVisibility, which keeps the picked pen and replans once.StringComparer.CurrentCulturethen id, where the deleted statement sorted by the database collation.docs/architecture/postgres-instance.md).Verification
dotnet test SemiPlot.slnx: unit 2605/2605, integration 214/214 (Docker).dotnet format --verify-no-changesanddotnet terseclean.docs/plans/completed/20261029-catalogue-read-and-group-fold.md).Closes #139
Refs #140
Per-task commits before collapse
🤖 Generated with Claude Code