Repository navigation
feat(export): list the export pens as checkboxes - #165
Merged
Merged
Conversation
The export window's pen list was a ListBox, so each row carried two states, the tick and a row selection, and a click could select a row without ticking it. The list is now a bordered, virtualised column of checkboxes with one state per row. It stays one Tab stop; Up, Down, Home, End, PageUp and PageDown move the focus between the boxes and Space toggles one. The ListBoxItem palette keys nothing read any more are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The export window's pen list was a ListBox, so each row carried two states: the tick and a row selection. A click could select a row without ticking it, and the selection fill read as a second meaning.
What changed
ItemsControlof checkboxes over aVirtualizingStackPanel, one state per row, eight 28 px rows tall with a scroll bar that does not auto-hide.ListBoxItem*palette keys nothing reads any more are removed, with their theme test.docs/plans/completed/; the three pen editor plans from feat(pens): rework the pen editor window (#111) #164 get their move box ticked.Verification
SemiPlot.Tests.Unit: 2740 passed on the branch; the plan's acceptance filter 124 passed.dotnet format --verify-no-changesanddotnet terseclean.Per-task commits before collapse
🤖 Generated with Claude Code