Skip to content

feat(export): list the export pens as checkboxes - #165

Merged
mrcsin merged 1 commit into
masterfrom
export-pen-choice-list
Nov 9, 2026
Merged

mrcsin merged 1 commit into
masterfrom
export-pen-choice-list

Conversation

@mrcsin

@mrcsin mrcsin commented Nov 9, 2026

Copy link
Copy Markdown
Member

Problem

The export window's pen list was a ListBox, so each row carried two states: the tick and a row selection. A click could select a row without ticking it, and the selection fill read as a second meaning.

What changed

  • The list is a bordered ItemsControl of checkboxes over a VirtualizingStackPanel, one state per row, eight 28 px rows tall with a scroll bar that does not auto-hide.
  • It stays one Tab stop. Up, Down, Home, End, PageUp and PageDown move the focus between the boxes through a tunnel handler; Space toggles the focused box.
  • The ListBoxItem* palette keys nothing reads any more are removed, with their theme test.
  • The plan moves to docs/plans/completed/; the three pen editor plans from feat(pens): rework the pen editor window (#111) #164 get their move box ticked.

Verification

  • SemiPlot.Tests.Unit: 2740 passed on the branch; the plan's acceptance filter 124 passed.
  • dotnet format --verify-no-changes and dotnet terse clean.
  • Manual check on the live demo passed.
Per-task commits before collapse
22b8b00 docs(plans): archive the export pen list plan
d9b5965 docs(plans): record the export list exec run
9a19fb7 fix(export): keep the focus on page keys
7e3cc5a fix(export): address review findings
fbf6828 docs(export): describe the pen list as checkboxes
9150432 docs(plans): record the export list acceptance run
7d6d0b2 refactor(theme): drop the unread ListBoxItem keys
26606d0 feat(export): walk the pen list with the arrow keys
63d212a refactor(export): list pens as checkboxes, no rows

🤖 Generated with Claude Code

The export window's pen list was a ListBox, so each row carried two
states, the tick and a row selection, and a click could select a row
without ticking it. The list is now a bordered, virtualised column of
checkboxes with one state per row. It stays one Tab stop; Up, Down,
Home, End, PageUp and PageDown move the focus between the boxes and
Space toggles one. The ListBoxItem palette keys nothing read any more
are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mrcsin
mrcsin marked this pull request as ready for review November 9, 2026 15:02
@mrcsin
mrcsin merged commit c76b1c9 into master Nov 9, 2026
2 checks passed
@mrcsin
mrcsin deleted the export-pen-choice-list branch November 9, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant