Skip to content

feat(chart): put the log box in the axis scale form - #166

Merged
mrcsin merged 1 commit into
masterfrom
axis-scale-checkbox-column
Nov 9, 2026
Merged

mrcsin merged 1 commit into
masterfrom
axis-scale-checkbox-column

Conversation

@mrcsin

@mrcsin mrcsin commented Nov 9, 2026

Copy link
Copy Markdown
Member

Problem

The axis scale panel drew its Logarithmic checkbox under the labels, so the form had two left edges, and an invalid bound showed only a red border while the pen form also showed a warning glyph.

What changed

  • The box sits in the field column under a «Тип шкалы» label and reads «Логарифмическая», reusing the pen form's two strings; AxisScaleLogarithmic leaves both resx files.
  • The bounds grid and the new type row share one Auto label column through SharedSizeGroup, so the box starts at the fields' edge in both languages. The box keeps its own grid, so the pair's focus commit is unchanged.
  • An invalid bound shows the warning glyph inside its box. The glyph style lives once in Styles/Forms.axaml behind the invalid-glyph class, which the pen form and this panel turn on.
  • Only the box and its text toggle the flag; a click on the label gives the panel the keyboard.

Verification

  • SemiPlot.Tests.Unit: 2748 passed on the branch; the plan's acceptance filter 84 passed.
  • dotnet format --verify-no-changes and dotnet terse clean.
  • Manual check on the live demo passed.
Per-task commits before collapse
9b9e9a6 docs(plans): record the axis scale exec run
bea09dc fix(chart): address review findings
c881f79 docs(chart): describe the axis scale type row
dd72c6e docs(plans): record the axis scale acceptance run
34878a3 refactor(chart): drop the unread log scale key
9214cd7 feat(chart): show the warning glyph in an invalid bound
2dce5d6 feat(chart): move the log box into the field column
dc888f6 docs(plans): add the axis scale checkbox column plan

🤖 Generated with Claude Code

The axis scale panel drew its Logarithmic checkbox under the labels,
so the form had two left edges. The box now sits in the field column
under a Scale type label, reusing the pen form's two strings, and the
two grids share one Auto label column, so every field starts at one
edge. An invalid bound shows the warning glyph inside its box, through
one class-gated style the pen form shares. The resource key the panel
no longer reads is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mrcsin
mrcsin marked this pull request as ready for review November 9, 2026 15:08
@mrcsin
mrcsin merged commit 9d93398 into master Nov 9, 2026
2 checks passed
@mrcsin
mrcsin deleted the axis-scale-checkbox-column branch November 9, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant