Repository navigation
feat(chart): put the log box in the axis scale form - #166
Merged
Merged
Conversation
The axis scale panel drew its Logarithmic checkbox under the labels, so the form had two left edges. The box now sits in the field column under a Scale type label, reusing the pen form's two strings, and the two grids share one Auto label column, so every field starts at one edge. An invalid bound shows the warning glyph inside its box, through one class-gated style the pen form shares. The resource key the panel no longer reads is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The axis scale panel drew its Logarithmic checkbox under the labels, so the form had two left edges, and an invalid bound showed only a red border while the pen form also showed a warning glyph.
What changed
AxisScaleLogarithmicleaves both resx files.Autolabel column throughSharedSizeGroup, so the box starts at the fields' edge in both languages. The box keeps its own grid, so the pair's focus commit is unchanged.Styles/Forms.axamlbehind theinvalid-glyphclass, which the pen form and this panel turn on.Verification
SemiPlot.Tests.Unit: 2748 passed on the branch; the plan's acceptance filter 84 passed.dotnet format --verify-no-changesanddotnet terseclean.Per-task commits before collapse
🤖 Generated with Claude Code