Repository navigation
refactor(ui): put every inset on the spacing scale - #167
Merged
Merged
Conversation
The UI's AXAML carried 45 margins, paddings and spacings off the 4/8/12/16/24/32 scale (20, 14, 10, 6 and a few 2, 3 and 5 px), and the dialog buttons carried their own 12,2 padding. Each value now sits on the scale at the level it belongs to: 16 px window margins, 12 px label gaps, 8 px row gaps, 4 px inside a control. Text buttons take Semi's own 12,0 padding at 32 px. A git grep gate in ui-theme.md prints any off-scale inset left, and per-window tests read the realised insets back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mrcsin
marked this pull request as ready for review
November 9, 2026 15:14
mrcsin
added a commit
that referenced
this pull request
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The UI's AXAML carried 45 margins, paddings and spacings off the 4/8/12/16/24/32 scale (20, 14, 10, 6, and a few 2, 3 and 5 px), and 16 buttons carried literal paddings such as
12,2. Equal things had unequal insets, and nothing stopped a new off-scale value.What changed
12,0at 32 px; the sidebar's 24 px top-row buttons keep8,0.ui-theme.mdgains the section "An off-scale inset in AXAML is a defect" with agit grepgate, andAGENTS.mdpoints to it.Verification
SemiPlot.Tests.Unit: 2764 passed on the branch; the off-scale gate prints nothing; per-window tests read the realised insets back.dotnet format --verify-no-changesanddotnet terseclean.Per-task commits before collapse
🤖 Generated with Claude Code