Skip to content

refactor(ui): put every inset on the spacing scale - #167

Merged
mrcsin merged 1 commit into
masterfrom
ui-spacing-scale
Nov 9, 2026
Merged

mrcsin merged 1 commit into
masterfrom
ui-spacing-scale

Conversation

@mrcsin

@mrcsin mrcsin commented Nov 9, 2026

Copy link
Copy Markdown
Member

Problem

The UI's AXAML carried 45 margins, paddings and spacings off the 4/8/12/16/24/32 scale (20, 14, 10, 6, and a few 2, 3 and 5 px), and 16 buttons carried literal paddings such as 12,2. Equal things had unequal insets, and nothing stopped a new off-scale value.

What changed

  • Every inset sits on the scale at its level: 16 px window margins, 12 px label-to-field gaps, 8 px row gaps, 4 px inside a control. Settings, export, axis scale, time window, marker editor, sidebar, status bar, navigation bar and message panel.
  • Text buttons drop their literal padding and take Semi's 12,0 at 32 px; the sidebar's 24 px top-row buttons keep 8,0.
  • Sidebar rows grow from 20 to 24 px and one-line messages from 52 to 56 px (headless measurement; real-font re-measure is listed in the plan).
  • ui-theme.md gains the section "An off-scale inset in AXAML is a defect" with a git grep gate, and AGENTS.md points to it.

Verification

  • SemiPlot.Tests.Unit: 2764 passed on the branch; the off-scale gate prints nothing; per-window tests read the realised insets back.
  • dotnet format --verify-no-changes and dotnet terse clean.
  • Manual check on the live demo passed.
Per-task commits before collapse
21ff288 docs(plans): record the spacing scale exec run
f09b5ff fix(ui): address review findings
ee8d1c1 docs(ui): record the spacing scale and its gate
abe36f2 docs(plans): record the spacing scale verification
2ab1679 refactor(ui): put the sidebar and bar insets on the scale
dc432ad refactor(chart): put the panel insets on the scale
0d9874a refactor(export): put the window insets on the scale
d9446e6 refactor(settings): put the dialog insets on the scale
bd10a5e refactor(ui): drop literal padding from dialog buttons
a95daca docs(plans): add the ui spacing scale plan

🤖 Generated with Claude Code

The UI's AXAML carried 45 margins, paddings and spacings off the
4/8/12/16/24/32 scale (20, 14, 10, 6 and a few 2, 3 and 5 px), and
the dialog buttons carried their own 12,2 padding. Each value now
sits on the scale at the level it belongs to: 16 px window margins,
12 px label gaps, 8 px row gaps, 4 px inside a control. Text buttons
take Semi's own 12,0 padding at 32 px. A git grep gate in ui-theme.md
prints any off-scale inset left, and per-window tests read the
realised insets back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mrcsin
mrcsin marked this pull request as ready for review November 9, 2026 15:14
@mrcsin
mrcsin merged commit 962b8b3 into master Nov 9, 2026
2 checks passed
@mrcsin
mrcsin deleted the ui-spacing-scale branch November 9, 2026 15:19
mrcsin added a commit that referenced this pull request Nov 10, 2026
All seven slices merged in #164 to #167; the roadmap records each
slice's plan, pull request and branch.

Co-authored-by: Oleg <18466855+EvaTheSalmon@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant