Skip to content

feat(pens): edit the colour through the picker alone - #168

Merged
mrcsin merged 1 commit into
masterfrom
stock-control-ladder
Nov 9, 2026
Merged

mrcsin merged 1 commit into
masterfrom
stock-control-ladder

Conversation

@mrcsin

@mrcsin mrcsin commented Nov 9, 2026

Copy link
Copy Markdown
Member

Problem

The pen form had a hex text box beside the colour picker, though the picker's flyout already has a validated hex box, so two inputs wrote one value. The picker's arrow was hidden, which left its swatch with uneven corners. Several stock controls were restyled by reaching into Semi's templates, and the sidebar chevron and the group «...» button painted a hover square larger than the row.

What changed

  • The hex box, IsColorValid and the HexColor input layout are gone. The picker spans the 240 px field column with its own full-width swatch as Content, equal 4 px insets, and its arrow shown. A stored colour that does not parse shows its message on the form's message line.
  • ui-theme.md gains "How a stock control is customised": a ladder from a shipped theme, a public property and a palette key down to template selectors, which need a test that reads the result back. AGENTS.md points to it.
  • On that ladder: the fold chevron and the group «...» button use Semi's InnerIconButton and paint no fill in any state; the cell focus outline and the group grid's selected row move to palette keys (the grid's scoped to it and following a live theme switch); the date picker's PART_TextBox style lives once in Forms.axaml. Seven template selectors remain, each with a brush-reading test.

Verification

  • SemiPlot.Tests.Unit: 2739 passed after the picker change, 2742 after the ladder.
  • dotnet format --verify-no-changes and dotnet terse clean.
  • Manual check on the live demo passed.
Per-task commits before collapse
3e73cb4 refactor(ui): customise stock controls from the cheapest rung
323ae18 feat(pens): edit the colour through the picker alone

🤖 Generated with Claude Code

The pen form had a hex text box beside the colour picker, though the
picker's flyout already has a validated hex box: two inputs wrote one
value, and the picker's arrow was hidden, which left its swatch with
uneven corners. The hex box and its input layout are gone. The picker
spans the 240 px field column with its own full-width swatch and its
arrow shown.

Stock controls are now customised from the cheapest rung that reaches
the surface, written down in ui-theme.md: a shipped theme, a public
property, a palette key, then template selectors only with a test that
reads the result back. On that ladder the sidebar fold chevron and the
group menu button use Semi's InnerIconButton and paint no fill, the
cell focus outline and the group grid selection move to palette keys,
and the date picker style lives once in Forms.axaml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mrcsin
mrcsin marked this pull request as ready for review November 9, 2026 15:21
@mrcsin
mrcsin merged commit f9a852c into master Nov 9, 2026
2 checks passed
@mrcsin
mrcsin deleted the stock-control-ladder branch November 9, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant