Repository navigation
feat(pens): edit the colour through the picker alone - #168
Merged
Merged
Conversation
The pen form had a hex text box beside the colour picker, though the picker's flyout already has a validated hex box: two inputs wrote one value, and the picker's arrow was hidden, which left its swatch with uneven corners. The hex box and its input layout are gone. The picker spans the 240 px field column with its own full-width swatch and its arrow shown. Stock controls are now customised from the cheapest rung that reaches the surface, written down in ui-theme.md: a shipped theme, a public property, a palette key, then template selectors only with a test that reads the result back. On that ladder the sidebar fold chevron and the group menu button use Semi's InnerIconButton and paint no fill, the cell focus outline and the group grid selection move to palette keys, and the date picker style lives once in Forms.axaml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pen form had a hex text box beside the colour picker, though the picker's flyout already has a validated hex box, so two inputs wrote one value. The picker's arrow was hidden, which left its swatch with uneven corners. Several stock controls were restyled by reaching into Semi's templates, and the sidebar chevron and the group «...» button painted a hover square larger than the row.
What changed
IsColorValidand theHexColorinput layout are gone. The picker spans the 240 px field column with its own full-width swatch asContent, equal 4 px insets, and its arrow shown. A stored colour that does not parse shows its message on the form's message line.ui-theme.mdgains "How a stock control is customised": a ladder from a shipped theme, a public property and a palette key down to template selectors, which need a test that reads the result back.AGENTS.mdpoints to it.InnerIconButtonand paint no fill in any state; the cell focus outline and the group grid's selected row move to palette keys (the grid's scoped to it and following a live theme switch); the date picker'sPART_TextBoxstyle lives once inForms.axaml. Seven template selectors remain, each with a brush-reading test.Verification
SemiPlot.Tests.Unit: 2739 passed after the picker change, 2742 after the ladder.dotnet format --verify-no-changesanddotnet terseclean.Per-task commits before collapse
🤖 Generated with Claude Code