Repository navigation
feat(ui): keep the chart usable beside owned windows - #169
Merged
Merged
Conversation
The settings, export and pen editor windows opened modally, so the chart could not be panned or read while one was open. They now open as owned, non-modal windows, one of each kind per main window: a second request brings the open one to the front, restoring it when minimised. Escape closes each of them. Every close of these windows, the main window's included, waits for the window's own work: the pen editor's pending write, a running settings save, or a cancelled export deleting its partial file. Then it closes the window or the owner that asked. Exit and Restart now start at most one copy. About and the settings window opened from the startup failure window stay modal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The settings, export and pen editor windows opened with
ShowDialog, so the chart could not be panned or read while one was open. Making them non-modal opens new paths: a second menu request, and a main-window close while the editor holds an unsaved edit, a save runs, or an export writes its partial file.What changed
DialogOpener.ShowOrActivateopens the three windows withShow(owner).MainWindowViewModelkeeps one open view model per kind inOpenViewModels; a second request re-emits it and reads nothing, and the view brings the window to the front, restoring it when minimised.Windows/OwnedWindowClosingholds every close of a window, the owner's included, until that window's work ends: the editor's drain (IsIdle),SaveInFlight, orStopExport()deleting the partial file. It then closes the window or the owner that asked, and asks again on every close._isClosing). Leaving the editor still writes the pending edit once, now pinned by tests.overview.md#the-owned-windowsholds the rules, andAGENTS.mdgates the single route.Verification
SemiPlot.Tests.Unit: 2769 passed; the plan's acceptance filter 186 passed, each new hold test red with its guard removed.dotnet format --verify-no-changesanddotnet terseclean.Per-task commits before collapse
🤖 Generated with Claude Code