Repository navigation
test(repo): replace string assertions with typed checks - #192
Merged
Merged
Conversation
About 40 test files asserted on message text: Russian UI sentences, English error wording, log text and resource values typed out again in the test. Any wording change broke them, and the Cyrillic literals blocked the ASCII-only source rule. Many tests checked nothing real: duplicates, tautologies, wording pins and tests of test-only code. Those tests now check the error type and its public properties, message severity and counts, or a relation between two production outputs. One data-driven test replaces 11 English parity tests and covers every enumerated reason type, so swapped format arguments still fail it. The pointless tests are deleted, six members that were internal only for tests are private, and no C# file contains Cyrillic. Config loader tests keep their message checks, because those errors have no typed surface. Four defects found during the audit are fixed: - a duration of 24 hours or more (the 86400 s maximum shows as 24:00:00) was rejected on edit; hours 00 to 99 now parse and the property max decides the range - every text column turned hh:mm input into seconds, so a comment typed as 12:30 was stored as 45000; only time_hms columns parse durations - the unclosed For and unmatched EndFor warnings named 0-based steps; they now count from 1 like every other step reference - the start-time column carried a seconds label hard-coded in C#; it now shows the units of the property behind the step_duration column Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
About 40 test files asserted on message text: Russian UI sentences, English error wording, log text and resource values typed out again in the test. Any wording change broke them, and the Cyrillic literals blocked the ASCII-only source rule. Many tests checked nothing real: duplicates, tautologies, wording pins and tests of test-only code.
What changed
internalonly for tests areprivate.Docs/architecture/error-reporting.mdstates the assertion rule;CLAUDE.mdpoints to it.Four defects found during the audit are fixed:
hh:mminput into seconds (a comment12:30was stored as45000). Onlytime_hmscolumns parse durations, in both grids.Forand unmatchedEndForwarnings named 0-based steps. They now count from 1.step_duration.Verification
dotnet build SemiStep.slnx: 0 warnings, 0 errors.dotnet test SemiStep/SemiStep.Tests/SemiStep.Tests.csproj: 1408 passed, 0 failed.LC_ALL=C.UTF-8 git grep -lP '[\x{0400}-\x{04FF}]' -- 'SemiStep/*.cs': no output.12:30stays in a comment cell, a duration cell still parses, start-time units match the duration column.Per-task commits before collapse
🤖 Generated with Claude Code