Repository navigation
feat(plc): log every reconciliation outcome (#158) - #195
Merged
Merged
Conversation
On every sync enable, the PLC reconciliation decides whether the operator is asked to resolve a conflict between the PLC recipe and the local one. It ended at seven exits, three of which hand the local recipe to the PLC and look identical to "the recipes matched"; one of them logged nothing. A field log could not say which exit ran when the conflict dialog failed to appear, which is what the diagnosis of #158 needs. Every exit now produces a named outcome, logged once per reconciliation with the local step count and validity, the PLC step count and commit flag where known, and whether a conflict subscriber exists. A begin line at the Connected edge separates "never ran" from "ran and chose X". The PlcLifecycleManager log source is pinned at Information, so the lines appear at the default Warning level. No behaviour changes: every exit does what it did before. Tests assert the outcome, level and logged values, not log wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On every sync enable, the PLC reconciliation decides whether the operator is asked to resolve a conflict between the PLC recipe and the local one. It ended at seven exits; three hand the local recipe to the PLC and look identical to "the recipes matched", and one logged nothing. A field log could not say which exit ran when the conflict dialog failed to appear (#158).
What changed
PlcReconciliationOutcome), logged once per reconciliation with the local step count and validity, the PLC step count and commit flag where known, and whether a conflict subscriber exists.PlcLifecycleManagerlog source is pinned at Information, so these lines appear at the defaultWarninglevel.docs/readme.md§5 documents the lines.docs/rename.Verification
dotnet build SemiStep.slnx: 0 warnings, 0 errors.dotnet test SemiStep/SemiStep.Tests/SemiStep.Tests.csproj: 1434 passed, 0 failed (Area=Reconnect35,Area=Logging15).🤖 Generated with Claude Code