Repository navigation
test(repo): fail the run on skipped tests - #200
Merged
Merged
Conversation
A test marked Skip passed the run silently, so a test could stop running and nobody would notice. xunit.runner.json now sets failSkips, as in SemiSpec, and a skipped test fails dotnet test. Explicit performance probes count as not run, not skipped, and stay out of the default run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A test marked
Skipstops running and the suite still reports green, so a disabled test can go unnoticed.What changed
SemiStep.Tests/xunit.runner.jsonsetsfailSkips: true(same as SemiSpec), copied to the output by the test project.docs/perf/README.mdnotes that explicit perf probes still count as not run and fail nothing.Verification
Skiptoday;dotnet test: 1444 passed, 0 failed, same as master.Skipto one test made the run fail (FAIL_SKIP, exit 1); the edit was reverted.🤖 Generated with Claude Code