Repository navigation
Add --unpaired-access option, on by default - #293
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The security-sensitive settings behavior lacks regression coverage.
1 open finding
What changed in this PR
Adds default-enabled unpaired server access for TUI and daemon clients.
Changes:
- Adds CLI and settings controls for unpaired access.
- Synchronizes the setting to the pairing store.
- Documents behavior and security implications.
| File | Description |
|---|---|
sendspin/settings.py |
Adds and loads the new setting. |
sendspin/cli.py |
Parses, validates, and applies the option. |
README.md |
Documents configuration and pairing behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Adds
--unpaired-accessand anunpaired_accesssetting, so servers can play on this client without pairing.It's on by default, since the CLI has no audio input role and Music Assistant approves unpaired clients automatically. This way upgraded headless players don't need someone to catch the pairing PIN in the daemon log.
Installs that already have a pairing file start accepting unpaired servers after this.
--unpaired-access falsekeeps requiring pairing.Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocumentationmaintenancecidependencies