Repository navigation
[bazel] Make //codepropertygraph:tests run the actual tests - #1870
Merged
Merged
Conversation
max-leuthaeuser
force-pushed
the
max/bazel-test-fix
branch
from
October 19, 2026 11:00
293428b to
ff69f0c
Compare
ml86
reviewed
Oct 19, 2026
The target globbed src/main/scala and therefore ran 0 tests. - use src/test/scala and ship src/test/resources as data - add better-files (repin) and link the domain classes at runtime - resolve test resources via the Bazel runfiles lookup (CpgRunfilesLocator, same mechanism as in joern); ProjectRoot.relativise remains the fallback for sbt/IDE only
max-leuthaeuser
force-pushed
the
max/bazel-test-fix
branch
from
October 19, 2026 11:08
ff69f0c to
678acd8
Compare
ml86
approved these changes
Oct 19, 2026
| ":tests_java", | ||
| "//schema:domainClassesNeverLinked", | ||
| "//schema:java_proto", | ||
| "@maven//:com_github_pathikrit_better_files_3", |
Contributor
There was a problem hiding this comment.
Can you please make a followup PR that removes better_files? This seems to be one of the last cases where it is still in our codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//codepropertygraph:testsglobbedsrc/main/scalainstead ofsrc/test/scalaand therefore ran 0 tests while reporting PASSED.src/test/scalaand shipsrc/test/resourcesasdata.better-files(+ repin) which the tests use, and link the domain classes (//schema:domainClassesLinked) at runtime because the compile time target isneverlink.JoernRunfilesLocator): Bazel runfiles lookup first, fallback toProjectRoot.relativisewhich is only used by sbt/IDE. New test-onlyCpgRunfilesLocatorwith a Bazel implementation (src/test/javaBazel,rules_java//java/runfiles) and an sbt stub returning empty (src/test/java). Bazel tests do not rely onProjectRoot(noFILE_IN_PROJECT_ROOT).Testing
bazel test //codepropertygraph:tests: now runs 27 tests, all pass.sbt test: 27 tests pass.sbt scalafmtCheck Test/scalafmtCheck,bazel build //...,bazel run formatCheck: clean.