Repository navigation
Conversation
|
Thanks for the PR, and for tracking this down! I confirmed the cause on a Ziggo box: the YouTube app reports its logo as https://images.cdn.prod.apps.dmdsdp.com/appstore/….png. So the "appstore" in logo_lower check in is_launcher_app matches every app, not just launchers. Whenever TV metadata is cached, opening an app restores the last channel instead of showing the app. That matches the issue you linked. Before we merge, could you update the PR a bit? |
|
Removed the lines in the code. Always happy to help. |
is_launcher_app also returned True for any logo path containing "appstore". Ziggo now serves the logo of every app from such a path, so after watching a channel, opening YouTube or Netflix restored the cached channel instead of showing the app. Detect a launcher overlay by its name only, and add tests for the detection and for the cached-channel behaviour with launchers and real apps. Fixes Sholofly/lghorizon#310. Based on the investigation and the fix in #110. Co-authored-by: shortwood <54151322+shortwood@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Thanks again for finding this and for the fix! The CI lint check flagged the leftover unused variable, so to get this into the next release quickly I've included your change, the cleanup and tests in a new PR (#123 ), with you as co-author. I'll close this one once that's merged. |
Fix for issue Sholofly/lghorizon#310 (comment)