Skip to content

Fix for displaying streaming apps correctly - #110

Closed
shortwood wants to merge 2 commits into
Sholofly:devfrom
shortwood:dev
Closed

shortwood wants to merge 2 commits into
Sholofly:devfrom
shortwood:dev

Conversation

@shortwood

Copy link
Copy Markdown
Contributor

@Sholofly

Copy link
Copy Markdown
Owner

Thanks for the PR, and for tracking this down! I confirmed the cause on a Ziggo box: the YouTube app reports its logo as https://images.cdn.prod.apps.dmdsdp.com/appstore/….png. So the "appstore" in logo_lower check in is_launcher_app matches every app, not just launchers. Whenever TV metadata is cached, opening an app restores the last channel instead of showing the app. That matches the issue you linked.

Before we merge, could you update the PR a bit?
Please delete the two lines instead of commenting them out

@shortwood

Copy link
Copy Markdown
Contributor Author

Removed the lines in the code. Always happy to help.

Sholofly added a commit that referenced this pull request Oct 31, 2026
is_launcher_app also returned True for any logo path containing
"appstore". Ziggo now serves the logo of every app from such a path, so
after watching a channel, opening YouTube or Netflix restored the cached
channel instead of showing the app.

Detect a launcher overlay by its name only, and add tests for the
detection and for the cached-channel behaviour with launchers and real
apps.

Fixes Sholofly/lghorizon#310. Based on the investigation and the fix in
#110.

Co-authored-by: shortwood <54151322+shortwood@users.noreply.github.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
@Sholofly

Copy link
Copy Markdown
Owner

Thanks again for finding this and for the fix! The CI lint check flagged the leftover unused variable, so to get this into the next release quickly I've included your change, the cleanup and tests in a new PR (#123 ), with you as co-author. I'll close this one once that's merged.

@Sholofly Sholofly closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants