Repository navigation
Report rejected credentials through a callback - #121
Merged
Merged
Conversation
When the provider revoked the credentials or refresh token while the client was running, the hourly token refresh and the MQTT reconnect loop only logged an error, so the owner never learned that a new login was needed. LGHorizonAuth now takes an auth_failure_callback that is called when a token request is rejected as unauthorized. It is called once per failure streak and again after a token request has succeeded in between. LGHorizonApi.set_token_refresh_callback set a token_refresh_callback attribute that LGHorizonAuth did not have, so it had no effect. Add the property. Fix the README example, which passed an async callback that the library calls synchronously, and document both callbacks. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the provider revoked the credentials or refresh token while the client was running, the hourly token refresh and the MQTT reconnect loop only logged an error, so the owner never learned that a new login was needed.
LGHorizonAuth now takes an auth_failure_callback that is called when a token request is rejected as unauthorized. It is called once per failure streak and again after a token request has succeeded in between.
LGHorizonApi.set_token_refresh_callback set a token_refresh_callback attribute that LGHorizonAuth did not have, so it had no effect. Add the property. Fix the README example, which passed an async callback that the library calls synchronously, and document both callbacks.