Repository navigation
Make sure we actually have session data before trying to set it - #9858
Merged
Merged
Conversation
Signed-off-by: oldiesmann <oldiesmann@gmail.com>
Signed-off-by: oldiesmann <oldiesmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my local test boards, I'm seeing "Cannot use bool as array" errors from Session.php in the error log immediately after visiting one of the boards for the first time as a guest (such as in a private window). When the session starts, there won't be any data in the database for the forum to load, but we always assume there is. This remedies that situation by making sure we actually have info before trying to assign those values to an array.