Repository navigation
[3.0] Change return mode to enum - #9859
Open
jdarwood007 wants to merge 1 commit into
Open
jdarwood007 wants to merge 1 commit into
jdarwood007 wants to merge 1 commit into
Conversation
jdarwood007
force-pushed
the
3.0/returnMode
branch
from
November 8, 2026 21:31
7074824 to
9487a3a
Compare
dragomano
reviewed
Nov 9, 2026
|
|
||
| case Off = 0; | ||
| case SingleRow = 1; | ||
| case MultieRow = 2; |
Contributor
There was a problem hiding this comment.
Small inconsistency here: the docblock for insert() in DatabaseApiInterface refers to
ReturnMode::MultiRow, but the case itself is named MultieRow. Looks like a typo in the case name.
Member
Author
There was a problem hiding this comment.
At least I spelled it wrong everywhere. Fix sent up.
jdarwood007
force-pushed
the
3.0/returnMode
branch
from
November 9, 2026 12:24
9487a3a to
8a2367c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.