Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
ArdaTkn
force-pushed
the
feat/draft-graph-config
branch
from
November 19, 2026 22:48
c3f0417 to
fb2a30f
Compare
SkyeAv
requested changes
Nov 19, 2026
SkyeAv
left a comment
Owner
There was a problem hiding this comment.
Thanks, @ArdaTkn! The command looks useful, and the targeted tests pass (9 passed). A few small follow-ups:
- Prevent
--forcefrom overwriting an input table whenoutput.resolve()matches one oftables; add a regression test. Directory outputs should also fail cleanly. - Add
draftto the CLI command list indocs/index.md:36. - If #288 lands first, add
assert graph.rig is not Nonebeforetests/test_draft.py:54so pyright still passes.
No other blocking findings. Thanks!
Contributor
Author
|
Addressed all review items in
Local gates re-run and passing: |
ArdaTkn
force-pushed
the
feat/draft-graph-config
branch
from
November 19, 2026 23:29
fb2a30f to
5d4cd3f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #270.
Summary
tablassert draft TABLES... [-o OUTPUT] [--force]insrc/tablassert/cli.py:namefrom the first table stem, setsversion: 0.1.0andfullmap: .fullmap, and populates honestDRAFTRIG placeholders (infores:tablassert-draft).Graph.model_validatebefore writing, sotablassert validate --schema graphpasses immediately.ingests.to_yamlfor formatting and prepends a# DRAFTheader comment; refuses to overwrite an existing file unless--forceis passed.tablassert draftindocs/cli.mdandllms.txt, and register it intests/test_docs_cli_coverage.pyandvulture_whitelist.py.tests/test_draft.pyand anUnreleasedchangelog entry inCHANGELOG.md.Local gate
scripts/check_changelog.py --base upstream/main: PASSruff check ./ruff format --check .: cleanpyright: 0 errorsvulture/deptry .: cleanmkdocs build --strict: cleanpytest tests/test_draft.py tests/test_docs_cli_coverage.py tests/test_docs_source_of_truth.py tests/test_docs_style.py tests/test_docs_examples.py: all passed