Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
0eee21f to
7d8742e
Compare
SkyeAv
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @ArdaTkn! The config scaffolding and validation flow look good. Thinking it through, generating an example data file is probably not the best behavior for init: it suggests a runnable build even though the user still needs a fullmap and real source data. Could we remove the sample data scaffolding and keep init focused on graph.yaml and tables/table.yaml?
- Remove the
data/sample creation insrc/tablassert/cli.py:1084-1095; leavelocalas a placeholder path for the user to replace. - Update
docs/cli.md,CHANGELOG.md, andtests/test_init.pyso the command promises and checks only schema-valid configs and overwrite protection. - This also avoids format-specific gaps such as the excel branch currently writing no sample workbook.
I am updating the success metric in #276 to match this scope. The YAML scaffold and validate --schema graph flow look sound.
|
Addressed your review in
Local gates re-run and passing: |
7d8742e to
0b01322
Compare
|
Also updated |
0b01322 to
ace1b33
Compare
ace1b33 to
8a121aa
Compare
Closes #276.
Summary
tablassert init [NAME] [--kind excel|text|parquet|ipc|ndjson] [--force]insrc/tablassert/cli.py:graph.yaml(with honestDRAFTRIG placeholders,infores:tablassert-draft),tables/table.yaml, and a sample data file indata/for the chosen--kind.SectionandGraphmodels before writing, sotablassert validate <dir>/graph.yaml --schema graphpasses immediately.graph.yamlortables/table.yamlwithout--force, and prints a next-steps checklist.tablassert initindocs/cli.md,docs/tutorial.md, andllms.txt, and register it intests/test_docs_cli_coverage.pyandvulture_whitelist.py.tests/test_init.py, plus anUnreleasedchangelog entry inCHANGELOG.md.Local gate
scripts/check_changelog.py --base upstream/main: PASSruff check ./ruff format --check .: cleanpyright: 0 errorsvulture/deptry .: cleanmkdocs build --strict: cleanpytest tests/test_init.py tests/test_docs_cli_coverage.py tests/test_docs_source_of_truth.py tests/test_docs_style.py tests/test_docs_examples.py: all passed