Skip to content

feat: add identified CURIE passthrough to skip fullmap resolution - #292

Open
ArdaTkn wants to merge 1 commit into
SkyeAv:mainfrom
ArdaTkn:feat/curie-passthrough
Open

ArdaTkn wants to merge 1 commit into
SkyeAv:mainfrom
ArdaTkn:feat/curie-passthrough

Conversation

@ArdaTkn

@ArdaTkn ArdaTkn commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Closes #272.

Summary

  • Add IdentifiedSpec (name, category encodings) and NodeEncoding.identified in src/tablassert/models.py:
    • Mutually exclusive with fullmap resolution options (taxon, taxon_from, prioritize, avoid, exclude_prefixes, exclude_regex) via identified-resolution-conflict.
    • Validates literal identified.category at config time (identified-bad-category) and rejects identified on qualifiers (qualifier-identified-unsupported).
    • Makes Graph.fullmap optional when every node column uses identified passthrough; validate and build-kg fail with fullmap-required if any column still needs resolution.
  • Update Tcode._node_ops, Tcode.collect, and _collect_subframes in src/tablassert/lib.py to skip resolve_batch and fullmap_audit for passthrough columns, validate CURIEs/categories via passthrough_audit, and log passthrough status in QC via passthrough_qc_audit.
  • Update docs/configuration/table.md, docs/configuration/graph.md, tests/test_docs_source_of_truth.py, CHANGELOG.md, and add tests/test_curie_passthrough.py.

Local gate

  • scripts/check_changelog.py --base upstream/main: PASS
  • ruff check . / ruff format --check .: clean
  • pyright: 0 errors
  • vulture / deptry .: clean
  • mkdocs build --strict: clean
  • pytest tests/test_curie_passthrough.py tests/test_docs_source_of_truth.py tests/test_docs_style.py tests/test_models.py: 350 passed

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 28248948-fb96-4cd1-9e40-ddffe788ec23
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ArdaTkn
ArdaTkn force-pushed the feat/curie-passthrough branch from 733dd59 to a91697b Compare November 19, 2026 22:39
@ArdaTkn
ArdaTkn force-pushed the feat/curie-passthrough branch from a91697b to 91f338a Compare November 19, 2026 23:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip fullmap resolution when subject/object is already a CURIE with name and category

1 participant