Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
SkyeAv
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @ArdaTkn! The extra, the preflight check and the tests look good, and CI passes. One docs update before merging:
- Excel Source docs:
docs/configuration/table.md:90should say thatkind: excelwith the defaultcalamineengine now needstablassert[excel]. Config authors will look there first, andtablassert[cli]users with Excel tables will hitMissingExtraErrorafter upgrading. A short note with the install command and a link to the extras section indocs/installation.mdwould cover it.
Thanks again!
|
Added the Verified locally with |
b031d3f to
e2e1e85
Compare
e2e1e85 to
f664959
Compare
|
Thanks, @ArdaTkn! The Excel Source callout looks good. I found two remaining setup commands that need
Both currently end at |
Closes #300.
Summary
fastexcel>=0.21.0fromproject.dependenciesto[project.optional-dependencies].excelinpyproject.tomland regenerateuv.lock."excel": {"fastexcel": "fastexcel"}inEXTRA_PACKAGESand"excel": "Excel input"inFEATURESinsrc/tablassert/extras.py.extras.require("excel", required_by="Excel input")inlib.excel()only whenengine == "calamine", raisingMissingExtraErrorbefore callingpl.read_excel()while leaving explicit engines such asopenpyxlindependent.--extra exceltoMakefile,.github/workflows/ci.yml,.github/workflows/security.yml,CONTRIBUTING.md,README.md,docs/installation.md, andllms.txt, and add an Unreleased### Changedentry inCHANGELOG.md.tests/test_extras.pyandtests/test_cover_lib.pywith[excel]registry coverage,MissingExtraErrorpreflight checks, andopenpyxlindependence whenfastexcelis absent.Local gate
uv lock --check: passscripts/check_changelog.py --base upstream/main: PASSruff check ./ruff format --check src tests docs: cleanpyright: 0 errorsvulture/deptry .: cleanmkdocs build --strict: cleanpytest tests/test_extras.py tests/test_cover_lib.py tests/test_docs_source_of_truth.py tests/test_docs_style.py: 255 passed